Transparent site logos?

darkpixlz · March 16, 2025, 7:47pm

I don’t remember it being like this back in the day, but I’m trying to upload an image right from Figma, which is transparent from my clipboard, but Discourse is turning it into a white jpeg:

Is there something I can do to stop this?

Arkshine · March 16, 2025, 8:36pm

I think I can see why.

The uploader component used in site settings has a parameter to tell the backend to not convert to JPEG:

github.com/discourse/discourse

app/assets/javascripts/admin/addon/components/site-settings/upload.hbs

main


      
          <UppyImageUploader
            @imageUrl={{this.value}}
            @placeholderUrl={{this.setting.placeholder}}
            @onUploadDone={{this.uploadDone}}
            @onUploadDeleted={{fn (mut this.value) null}}
            @additionalParams={{hash for_site_setting=true}}
            @type="site_setting"
            @id={{concat "site-setting-image-uploader-" this.setting.setting}}
          />

After the logo page has been rebranded, the form uses FormKit.
However, the param is missing here:

github.com/discourse/discourse

app/assets/javascripts/discourse/app/form-kit/components/fk/control/image.gjs

main


      
          <UppyImageUploader
            @id="{{@field.id}}-{{@field.name}}"
            @imageUrl={{this.imageUrl}}
            @onUploadDone={{this.setImage}}
            @onUploadDeleted={{this.removeImage}}
            @type={{@type}}
            @disabled={{@field.disabled}}
            @placeholderUrl={{@field.args.placeholderUrl}}
            class="form-kit__control-image no-repeat contain-image"

darkpixlz · March 16, 2025, 8:36pm

So this sounds like more of a Bug?

I’m sure it’s an easy fix I’m just unsure as to how it works at all.

darkpixlz · March 16, 2025, 8:47pm

Seems to be happening globally.

Arkshine · March 16, 2025, 8:49pm

Yes, I would say a bug. It doesn’t have the same behavior when you go the Branding tab in the settings.

For now, even if less convenient, you can use the settings in Branding.

darkpixlz · March 16, 2025, 8:56pm

Still seems to be uploading white here. Is it hidden somewhere else? I’m still used to the old-style bar navigation of 2022… this admin sidebar is like teaching an old dog new tricks

Arkshine · March 16, 2025, 8:57pm

I meant here /admin/site_settings/category/branding

The image shows a screenshot of a Discord admin panel, highlighting the "All site settings" menu, which includes options for Branding, Logo, and Basic Setup, and an arrow pointing to a section labeled "What's new?" (Captioned by AI)625×376 23.9 KB

Topic		Replies	Views
Very small PNGs are inappropriately converted to JPGs Bug	23	1781	November 23, 2018
Why default to converting PNG to JPG? Feature	19	3979	November 22, 2020
Discourse uploads image in wrong format Support	2	1035	November 25, 2018
Problem with category image transparency Support	11	1389	March 5, 2021
Remote image conversion ignores jpg quality setting Bug	2	435	August 30, 2021

Transparent site logos?

Related topics