Unable to alter the lock icon in category boxes

Johani · December 15, 2021, 6:39am

Some of this is in core, and some of it is in the component. These two PRs should fix the issue when merged

github.com/discourse/discourse

UX: allow themes to easily change in the lock icon in category-boxes

discourse:main ← hnb-ku:category-boxes-lock-icons

opened 06:27AM - 15 Dec 21 UTC

hnb-ku

+4 -2

Context: https://meta.discourse.org/t/unable-to-alter-the-lock-icon-in-category-…boxes/212133 Instead of hardcoding the category lock icon, set it as a property that themes can override. This means that themes can avoid full template overrides. The category title link already does that here. https://github.com/discourse/discourse/blob/1472e47aae5bfdfb6fd9abfe89beb186c751f514/app/assets/javascripts/discourse/app/components/category-title-link.js#L5 https://github.com/discourse/discourse/blob/70eca1dc4e04e94eb326482b51ea2617656fa8a8/app/assets/javascripts/discourse/app/templates/components/category-title-link.hbs#L5 This PR makes it so the `categories-boxes` and `categories-boxes-with-topics` also do the same.

github.com/discourse/discourse-category-icons

UX: allow component to change lock icons in category boxes

discourse:main ← hnb-ku:category-boxes-lock-icons-fix

opened 06:30AM - 15 Dec 21 UTC

hnb-ku

+10 -0

context: https://meta.discourse.org/t/unable-to-alter-the-lock-icon-in-category-…boxes/212133 I sent a PR to fix the core side of this here https://github.com/discourse/discourse/pull/15309 This PR makes the same adjustment here https://github.com/discourse/discourse-category-icons/blob/main/javascripts/discourse/initializers/category-icons.js#L21-L23 to the `categories-boxes` and `categories-boxes-with-topics` components.

Topic		Replies	Views
Private categories padlock icon UX	9	1496	May 19, 2023
Add category icons in the sidebar Feature sidebar , category-icons	8	375	September 4, 2023
Hide Lock Badge Icon Theme component	28	1468	July 31, 2024
Substitute Link Icon Only For Sharing UX	13	1531	November 1, 2021
Alternatives to lock icon for categories UX	67	6899	May 18, 2018

Unable to alter the lock icon in category boxes

Related Topics