Unable to copy public key when installing theme from private repository using Firefox

Bug
1

In Firefox, it’s impossible to select and copy the public key that is shown in Admin - Customize - Themes - Import - From the Web - “Theme is in a private git repository”

You cannot select the text from the textarea when the disabled attribute is set in Firefox.
AFAIK, the readonly attribute should be used here instead of disabled.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea:

readonly

This Boolean attribute indicates that the user cannot modify the value of the control. Unlike the disabled attribute, the readonly attribute does not prevent the user from clicking or selecting in the control. The value of a read-only control is still submitted with the form.

6 Likes
3

Thanks! Fixed in

https://github.com/discourse/discourse/pull/6424

I also took the chance to review other uses of the disabled attribute in Discourse, and all is good :+1:

11 Likes
4

This topic was automatically closed after 2 days. New replies are no longer allowed.