Uncategorized showing up on mobile

Bug
16

I submitted a fix for the bug in the first post:

https://github.com/discourse/discourse/pull/12889

I went with the first solution because that is the one that deletes some code from Discourse. The other one in fact added code to determine if there is at least one topic in uncategorized category.

I also reviewed all uses of category.uncategorized? and I found a few places that might not be necessary if we made Uncategorized less of a unicorn and more of a category:

https://github.com/discourse/discourse/blob/af6d0342b642feac3a5e359d13c854d2a80145b6/app/controllers/list_controller.rb#L372-L378

https://github.com/discourse/discourse/blob/3e7f7fdde8dd4ad92a34352ec927b2cdfbf91416/app/serializers/basic_category_serializer.rb#L43-L57

https://github.com/discourse/discourse/blob/eeaecd4fd2216f909e643554b0ee7f728944c2c4/app/models/category.rb#L898

These are some parts that do not interfere with other features, which makes the changes less risky, but still not easy.

6 Likes