Unlisted topic appears in RSS feed

[MarcP]

RSS feed (/latest.rss) items show unlisted topics, this should not be the case

I’m on this mornings build (7009f9c95e)

[sam (Sam Saffron)]

Are we certain this is not a caching issue? Does it vanish once the cache expires?

[MarcP]

I’ll keep monitoring my feed daily, so far the topic is still in the feed.

[Don]

Hello,

I checked this:

First check on d5f6262c4f which is about 2 days earlier then your Discourse version.

Here is the listed Welcome topic.

Now I unlist it.

No found, so this is works as expected on this version. Now I update to the latest version Discourse which is now the b75dc04a25.

---

And it still no found so I cannot repro this on the very latest Discourse. I think you have to try to update to the latest version.

---

Just to be sure I list it again

and unlist…

[RGJ (Richard - Communiteq)]

Nope, can’t reproduce this either.

[MarcP]

I just listed/unlisted the topic, and it’s still visible in the RSS feed.

Strange tho… not sure what else I can try.

[sam (Sam Saffron)]

Any possibility this is plugin related?

[MarcP]

Hmm for some reason after I did some more testing, and it seems to work now as expected

Thanks for the help.

[iidbae]

Same experience here with same build 7009f9c95e. Topic and reply are also appear in RSS feed.

My case, comment/reply after topic become unlisted is appear.

Previously, the topic is public then it unlisted.
thank you

[MarcP]

I have to rectify, the issue is still there but in /posts.rss - now with posts.rss I also have some very inconsistent behavior

• when logged in I get an error (Oops, page is private) when opening /posts.rss
• Incognito /posts.rss loads as I would expect
• somehow my RSS reader (feeder.co) can read the feed when it’s added including the unlisted topic
• the same RSS reader browser extension, which also prettifies .rss pages to readable format can’t fetch the page directly: “This feed is empty”
  • unwanted feed item in question is OP of a topic, not sure why it’s in /posts.rss

[sam (Sam Saffron)]

Hmmm…

discourse/discourse/blob/d1d0241d8bebf042a59c47d031f7f7189155cfa2/app/controllers/posts_controller.rb#L81-L88

discourse/discourse/blob/d1d0241d8bebf042a59c47d031f7f7189155cfa2/app/models/post.rb#L95-L95

Yeah looks like we are not omitting unlisted from the posts.json route.

We will get that sorted over the next week, need to decide how we do the omission. It is probably technically correct to remove it from the public_posts scope since it already joins into topic, but we need to carefully test.

[Roman_Rizzi]

Should be fixed by:

FIX: Exclude hidden topic posts and small actions from the RSS feed.

I also noticed we included small actions in the feed, so I filtered them out.