Unnecessary code on the website?


(Evgeny) #1

I looked at the code for this and three other sites (as seen by the search robot) and found on page (./latest) weird code. What is it?

in the template views-site/list/list.erb it is not. Templates clean. I didn’t look further.


(Bhanu Sharma) #2

Does this exists here on meta as well?

if not then check the customize section of Your website and look if anything unnecessary is left over in your </head> & after header section.


(Evgeny) #3

This is a screenshot from this website: Discourse Meta (in the screenshot)
I checked on three different websites, two independent scanners.


(Bhanu Sharma) #4

Okay! thanks for pointing out!..

I never had really observed this but it does exists on my sandbox and production instances as well so maybe it is something left out. someone from dev team may fix it :wink:


(Sam Saffron) #5

Great catch @Stranik!

Fixed per:

@eviltrout can you review, I think that was your intention there, to allow plugin to unconditionally replace the noscript header?


(Evgeny) #6

Everything is corrected. Thank you! The question can be closed.


(Sam Saffron) #7

(Robin Ward) #8

Yes - the patch is subtle here. The trick is not to return the result too and instead return nil? That makes sense.