Unwanted `div` tag should be removed inside `ol`

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/templates/components/bread-crumbs.hbs#L13

We didn’t needed the line I mentioned above. It is just creating output like

<ol class="category-breadcrumb">
 <li class="no-category has-drop bullet"></li>
 <li class="tag-drop no-category bullet tag_all"></li>
 <div class="clear"></div>
</ol>

Totally no need for div here inside a ol tag, At least it should be

 <li class="clearfix"></li>

Can anyone confirm it? So I can make PR.

4 Likes

Absolutely should be removed, but we got to make sure the ol does a proper clearfix.

2 Likes