Update failed for some reason?

Benjamin_D · March 30, 2022, 9:52pm

Hi,
this seems related to

and

seems this commit didn’t fix the previous issue ?

github.com/discourse/discourse

DEV: Re-add polymorphic bookmark columns (#16261)

committed 02:43AM - 23 Mar 22 UTC

martin-brennan

+3 -30

This commit is a redo of2f1ddadff7dd47f824070c8a3f633f00a27aacde which we rever…ted because it blew up an internal CI check. I looked into it, and it happened because the old migration to add the bookmark columns still existed, and those columns were dropped in a post migrate, so the two migrations to add the columns were conflicting before the post migrate was run. ------ This commit only includes the creation of the new columns and index, and does not add any triggers, backfilling, or new data. A backfill will be done in the final PR when we switch this over. Intermediate PRs will look something like this: Add an experimental site setting for using polymorphic bookmarks, and make sure in the places where bookmarks are created or updated we fill in the columns. This setting will be used in subsequent PRs as well. Listing and searching bookmarks based on polymorphic associations Creating post and topic bookmarks using polymorphic associations, and changing special for_topic logic to just rely on the Topic bookmarkable_type Querying bookmark reminders based on polymorphic associations Make sure various other areas like importers, bookmark guardian, and others all rely on the associations Prepare plugins that rely on the Bookmark model to use polymorphic associations The final core PR will remove all the setting gates and switch over to using the polymorphic associations, backfill the bookmarks table columns, and ignore the old post_id and for_topic colummns. Then it will just be a matter of dropping the old columns down the line.

and

Topic		Replies	Views
Recovering from failed/partially applied upgrade Installation	49	2375	August 12, 2022
Help! Upgrade led to complete fail Installation	8	1294	March 9, 2021
Upgrade failed: ERROR: relation "idx_regular_post_search_data" already exists Installation	3	606	September 20, 2020
Migration failed: relation "user_required_fields_versions" already exists Installation unsupported-install	19	201	September 9, 2024
Migration from discourse v2.8.13 (on Ubuntu 20.04.6 LTS) to latest Installation	4	643	August 15, 2023

Update failed for some reason?

Related topics