User data exports do not expire after 48 hours

RGJ · March 31, 2019, 10:53am

When you create an export of your user data, the notification message says

The above download link will be valid for 48 hours.

However, that does not seem to be the case: the file can still be downloaded after 48 hours (verified here on Meta)

The retain_hours field in the Upload model does not seem to be actually used anywhere.

codinghorror · March 31, 2019, 4:05pm

Hmm any changes needed here @tgxworld?

tgxworld · April 2, 2019, 7:00am

@techAPJ Can you have a look at this? The validity of user exports regressed in https://github.com/discourse/discourse/commit/91bf10bd12291adddab3edab2d788050fd484d43 when the user exports were changed to be backed by uploads record. I was going to make a change to clean up user exports after 48 hours but saw a spec in the commit that says not to clean up user exports. The following method and a scheduled job to clean up the user exports isn’t working anymore because the exports are not in the custom csv_exports directory which we should probably clean up as well.

github.com

discourse/discourse/blob/d85240335bef8888faac9b93cd33b68f9c9ff2e3/app/models/user_export.rb#L4


class UserExport < ActiveRecord::Base
  belongs_to :user


  def self.remove_old_exports
    UserExport.where('created_at < ?', 2.days.ago).find_each do |user_export|
      file_name = "#{user_export.file_name}-#{user_export.id}.csv.gz"
      file_path = "#{UserExport.base_directory}/#{file_name}"


      File.delete(file_path) if File.exist?(file_path)
      user_export.destroy!
    end
  end


  def self.base_directory

This seems to be intentional and was added way back in 2014. I’m not sure if we still need to support it? @sam

https://github.com/discourse/discourse/commit/58eabb03e5d6283b25e9ddd4f070e32c65be43c3#diff-60328924b5c773b42aacabc0b5698af4

RGJ · April 2, 2019, 7:16am

Another thing I realized is that (it looks like) user data exports are served over the CDN if that is configured.
That doesn’t seem like a good idea?

sam · April 2, 2019, 8:31am

I don’t see any particular reason to remove this, the api is still tested and should work, no?

tgxworld · April 2, 2019, 8:42am

Yup the API still and can work but I just wasn’t sure if we required that feature anymore.

techAPJ · April 3, 2019, 8:02am

Fixed via:

sam · April 6, 2019, 7:12am

This topic was automatically closed after 2 days. New replies are no longer allowed.