ted
August 26, 2024, 7:35am
16
Hello!
I just merged a fix for this issue here:
discourse:main ← discourse:fix/required-fields-check
opened 07:07AM - 26 Aug 24 UTC
### What is the problem?
This check was checking the wrong scope, causing pro… blems in certain edge conditions, for example:
1. Admin adds an "on signup" field that isn't editable after signup.
2. Admin adds a "for all users" field.
3. User goes and fills up the "for all users" field from 2.
4. User is now stuck on the required fields page without any fields showing.
### How does this fix it?
We only consider "for all users" fields when asking if required custom fields are filled in.
The problem was only noticed by either creating a mix of “on signup” and “for all users” or by users who gained access by other means than “signing up”. This PR should hopefully address all cases.
2 Likes
