User Fields - weird signup behavior

ted · August 29, 2024, 2:46am

I found what is probably the root cause of this, and fixed it in a PR that has already been merged:

github.com/discourse/discourse

FIX: Fix incorrect check for required custom fields

discourse:main ← discourse:fix/required-fields-check

opened 07:07AM - 26 Aug 24 UTC

Drenmi

+5 -2

### What is the problem? This check was checking the wrong scope, causing pro…blems in certain edge conditions, for example: 1. Admin adds an "on signup" field that isn't editable after signup. 2. Admin adds a "for all users" field. 3. User goes and fills up the "for all users" field from 2. 4. User is now stuck on the required fields page without any fields showing. ### How does this fix it? We only consider "for all users" fields when asking if required custom fields are filled in.

Topic		Replies	Views
User Field Requirement (2) Bug user-custom-fields , fixed	8	147	August 29, 2024
User Field requirement Bug user-custom-fields	7	117	July 18, 2024
Saving edits on user preferences page with required custom fields is unclear UX	8	1604	June 12, 2017
User Fields Defined still showing up in signup Support	12	853	October 27, 2022
Adding and editing user custom fields Bug user-custom-fields	9	6238	March 20, 2015

User Fields - weird signup behavior

Related topics