You are right, that was just temporary advice to quickly solve the issue.
After a conversation on this topic, we realised that it was not the best approach and we changed it. From now on, group level setting doesn’t have to be adjusted.
Related PRs
discourse:main ← discourse:dev/move-more-client-settings-group
opened 03:57AM - 07 Feb 24 UTC
Affects the following settings:
* whispers_allowed_groups
* anonymous_postin… g_allowed_groups
* personal_message_enabled_groups
* shared_drafts_allowed_groups
* here_mention_allowed_groups
* uploaded_avatars_allowed_groups
* ignore_allowed_groups
This turns off `client: true` for these group-based settings,
because there is no guarantee that the current user gets all
their group memberships serialized to the client. Better to check
server-side first.
discourse:main ← lis2:group-based-settings-fix
opened 11:31PM - 18 Feb 24 UTC
Affects the following settings:
delete_all_posts_and_topics_allowed_groups
e… xperimental_new_new_view_groups
enable_experimental_admin_ui_groups
custom_summarization_allowed_groups
pm_tags_allowed_for_groups
chat_allowed_groups
direct_message_enabled_groups
chat_message_flag_allowed_groups
This turns off client: true for these group-based settings, because there is no guarantee that the current user gets all their group memberships serialized to the client. Better to check server-side first.