Users should be automatically removed from channels they can no longer access

AI-generated summary

The discussion revolves around a bug where users who lose access to a channel, such as being removed from staff, are not automatically removed from the channel. davidkingham reports the issue, noting that users remain listed as members despite no longer having access. j.jaffeux acknowledges the problem and confirms it’s a known internal TODO, but won’t be fixed before next week. mcwumbly clarifies that while users are still listed, they cannot see or send messages in restricted channels. sam expresses uncertainty about a fix, suggesting a periodic job to ensure consistency, but notes that the system already prevents access. mcwumbly adds that related fixes have been merged. sam then closes the issue, noting that new bugs can be opened if needed.

I’ve found a fairly major bug (I think) with the #Staff chat. When a user is removed from the staff they are not removed from the Staff chat. Unless there is some way to remove them that I am missing? It seems like this should be automatic.

9 Likes

Will deal with this later today :+1: thanks

8 Likes

We made a TODO of this internally, this won’t be fixed before next week for sure. It will be one of my priorities for next week, sorry about this.

7 Likes

One thing I want to clarify is that even though these users are still listed as members of the channel, users who are removed from staff or any other group cannot see channels to which they’ve lost access, and they cannot see or send messages within those channels.

It’s still misleading though, and we have this at the top of our list.

We’re going to get to it soon, and we plan to take the time it requires to sort through the various cases that may exist where users’ access and membership to channels may need to be removed.

9 Likes

This fell through the cracks, but I am honestly not sure what a reasonable fix is.

We could “ensure consistency” and run a job once in a while that removes people without access.

We could “hide the info” and not render the users without access that somehow are in a channel.

Before we do anything here we should decide on what our desired behavior is.

1 Like

Wait hmm… I never circled back here, but these are some related changes that were merged related to this:

https://github.com/discourse/discourse/pull/20344

https://github.com/discourse/discourse/pull/29193

2 Likes

cool, going to close this then, we can reopen new bugs if we discover new edge cases post these changes.

2 Likes