elijah
(Eli the Bearded)
February 3, 2017, 1:20am
1
I can reproduce this here.
Click the Search magnifying glass, enter a term, and check the box for “Search this topic”
Click the “Discourse” logo on the upper left.
Click the Search magnifying glass: nothing happens.
A little while later it comes back, but I don’t know if it is some activity I’m doing or what that fixes it.
5 Likes
This is a legit bug @tgxworld and I think Imgur was reporting it as well?
3 Likes
tgxworld
(Alan Tan)
February 3, 2017, 1:23am
3
Yup it is the same bug and I’m fixing it atm. Problem here is that the search context is not being reset after we navigate away from the route.
4 Likes
For me, none of the top right buttons work: search, hamburger, or user icon.
Edit: When I come back into the topic where I searched, the search is still showing. ie. it didn’t close when I navigated away from the page.
tgxworld
(Alan Tan)
February 3, 2017, 3:35am
5
PR in
https://github.com/discourse/discourse/pull/4684
I found another bug in the process where we did not refresh the results when the search context has changed/become invalid. If you are searching within a topic and you navigate to the home page and open the search menu again, the search results would still be scoped to the topic that you navigated from.
7 Likes
sam
(Sam Saffron)
July 18, 2018, 5:29am
6
This still acts really really strange … we got to fix it properly.
Search for legit here:
Close search by clicking anywhere
Click “home”
Click “Search”
@tgxworld can you sort this out so it behaves more sanely… I guess if we are not clearing the term we should at least properly reset the search results so it searches globally for legit
6 Likes
tgxworld
(Alan Tan)
August 8, 2018, 10:04am
8
Fixed in
https://github.com/discourse/discourse/commit/94622b451a19f0f5152280f146354ab663d06eb8
I’ll need to look at adding the test case next week because it wasn’t straight forward.
5 Likes
tgxworld
(Alan Tan)
August 20, 2018, 7:52am
9
4 Likes