vBulletin Emojis

For anyone who wants to relive the old days of vBulletin and bring back those emojis, have a look at the following plugin (and yes, several of them are animated)

Oh, and they do not interfere with the existing emojione emoticons, as these are all prefixed with ‘vb-’
https://github.com/cpradio/vb_emoji

A big thanks goes out to @eviltrout for his emoji extender!

18 Likes

Just a reminder that in the 1.2 release there will be:

  • choice of Emoji class from Google, Apple, Twitter, EmojiOne

  • custom Emoji support

1 Like

Yes, that looks really neat (btw). The vB ones really don’t fit in with the Google/Apple/Twitter… ones, so I see this still being the easiest way to quickly bring in the vB emoticons, but I do like the progress that was made here within Discourse.

Well, these vb ones don’t really fit in anywhere in my opinion :wink:

2 Likes

Well aware of that. As you are aware that the opinions of others are the existing ones don’t really fit in anywhere… So the opinions are mutual across both sides. I personally don’t care enough one way over another, I simply created the plugin as 1) a test to get used to the plugin framework, and 2) because I know our forum specifically wants it.

1 Like

I am just kidding. Just know, @cpradio, that I will always think of you as my

6 Likes

I always did consider myself a :laughing:

Too much?

3 Likes

Hahahahahaha. This was too good to just like.

1 Like

2 Likes

PSA: This plugin in the last few weeks has become broken with the latest release of Discourse, 2.5.0.beta2. Bye, bye, vbulletin emoticons. It was nice knowing ya. :’(

2 Likes

The plugin can be updated, the plugin is broken because of a great new feature that allows the creation of new emoji groups but we still can register new emojis via plugin

https://github.com/discourse/discourse/commit/0996c3b7b36c37c3b478985da6e968f54dc4835c

I think we’ll just need to add an element in the plugin.rb file, something like this:

register_emoji "doh", "/plugins/discourse-plugin-vb-emoticons/images/doh.gif", "vbulletin"

And it should work again

5 Likes

Thanks, @Steven. I see @cpradio is still active visiting the forums here, as of 3 days ago. If he doesn’t reply in a week, is it kosher if I fork his plugin (duly credited) using the fix you mention above?

1 Like

This fix doesn’t seem to be enough, we need to add some clear_cache command but I don’t really know how to do this for now. I’ll look into this.

I don’t mind maintaining it also, I have a similar plugin, so I can do some grouped upgrades when something changes.

2 Likes

That sounds like a plan! I appreciate it.

1 Like

@Steven, if you want, I can add you as a contributor to the existing repo. More than happy to share the responsibility. Sadly, it will take me awhile to get a dev environment built for discourse again, sadly, I haven’t had time to spend in it so I’ve discarded my setups for awhile now.

2 Likes

I’m ok with this, my github account is iunctis

I didn’t find a solution yet for emojis plugins to work, I’m missing the right commands to clear cache

2 Likes

Sent you an invite. If there are any others you want to be invited to, let me know. I did get my rig put back together late last night, but that is as far as I got, clean install of Discourse. I plan to look at it again tonight (time willing), worst case, tomorrow night.

3 Likes

This is weird and might not be an issue with the plugin itself. When I do a rebuild on a clean install of Discourse adding my plugin, I get the following error

Caused by:
NameError: uninitialized constant Plugin::Instance::Emoji
/var/www/discourse/lib/plugin/instance.rb:482:in `register_emoji'
/var/www/discourse/plugins/discourse-plugin-vb-emoticons/plugin.rb:12:in `activate!'
/var/www/discourse/lib/plugin/instance.rb:526:in `instance_eval'
/var/www/discourse/lib/plugin/instance.rb:526:in `activate!'
lib/discourse.rb:224:in `block in activate_plugins!'
lib/discourse.rb:221:in `each'
lib/discourse.rb:221:in `activate_plugins!'
/var/www/discourse/config/application.rb:280:in `block in <class:Application>'
/var/www/discourse/lib/plugin_initialization_guard.rb:5:in `plugin_initialization_guard'
/var/www/discourse/config/application.rb:279:in `<class:Application>'
/var/www/discourse/config/application.rb:62:in `<module:Discourse>'
/var/www/discourse/config/application.rb:61:in `<top (required)>'
/var/www/discourse/Rakefile:7:in `require'
/var/www/discourse/Rakefile:7:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'

Note the first two lines:

NameError: uninitialized constant Plugin::Instance::Emoji
/var/www/discourse/lib/plugin/instance.rb:482:in `register_emoji'

@joffreyjaffeux, any ideas why it can’t find the constant? It seems to be looking within the wrong namespace.

3 Likes

I think it would work nicely if you wrapped all your register_emoji calls inside, an after_initialize block

Screenshot 2020-04-08 at 22.57.38

Is it something you can do ?

6 Likes

Indeed that works! Thanks!

3 Likes