Version check is incorrectly comparing stable and beta versions

We’ve just updated to Discourse 2.5 (stable version), and this component (as well as the new Topic Thumbnails one) is still disabled:

Help!

2 Likes

Hi Chris - thanks for this. Looks like we have a bug in our version check code. 2.5.0 should be considered greater than 2.5.0.beta2, but right now it’s not. That’s what is causing the theme to be auto-disabled.

I just opened a PR with a fix:

https://github.com/discourse/discourse/pull/10135

I’m going to split this into its own topic, and will let you know once the fix is live in the stable branch.

9 Likes

That’s now merged, so the theme version check should work correctly now. @cjk77 head to /admin/upgrade to update (you won’t receive a new version notification straight away)

4 Likes

@cjk77 I have updated your forum and that message has disappeared now.

@david thanks!

4 Likes

Confirmed to be working as intended! Thank you both @david and @RGJ!!!

3 Likes