Webpush gem is not latest

(Darix) #1

any reason for this?

(Jeff Wong) #2

it’s a dependency that was working in the plugin when we migrated. There appears to have been some issues in the past with those libs sometimes breaking and not sending notifications. I wanted no chance of that happening while I was porting, so I used dependencies I knew were working.

What does that particular patch give you that you’re missing?

(Darix) #3

I am packaging discourse as an rpm. And was wondering why we were using not the latest version for a feature that is just added. in general Gemfile dependencies tend to get stale especially when it is so tightly locked down as in this case.

(Mittineague) #4

As best as I can determine the more recent version of the gem added JWT (JSON Web Token) headers. This could be important to authenticate the notification as coming from Discourse. But I am not knowledgeable enough in this area to know how applicable that is here.

(Jeff Wong) #5

This is now no longer pinned per Don't pin version for the webpush gem. · discourse/discourse@5993a3a · GitHub

(Darix) #6

Thank you! This will make my life easier in the long run

(Jeff Wong) #7

This topic was automatically closed after 32 hours. New replies are no longer allowed.