When should Discourse upgrade to Rails 5?

Rails 5 broke a few of my plugins because of the change from before_filter to before_action.

I did a quick search through github.com/discourse/all-the-plugins for before_filter and found these other ones that will be broken:

./plugins/babble/app/controllers/posts_controller.rb:4:  before_filter :ensure_logged_in, except: :index
./plugins/babble/app/controllers/topics_controller.rb:4:  before_filter :set_default_id, only: :default
./plugins/babble/app/controllers/topics_controller.rb:5:  before_filter :ensure_logged_in, except: [:show, :index]
./plugins/blog/app/controllers/blog/application_controller.rb:8:    before_filter :cache_anon
./plugins/discourse-admin-statistics-digest/lib/admin_statistics_digest/active_user.rb:35:    signed_up_before_filter = if filters.signed_up_before
./plugins/discourse-admin-statistics-digest/lib/admin_statistics_digest/active_user.rb:88:                    #{ signed_up_before_filter }
./plugins/discourse-atom-receiver/app/controllers/discourse_atom_receiver/atom_file_controller.rb:5:    skip_before_filter :check_xhr
./plugins/discourse-blogger-plugin/plugin.rb:33:    skip_before_filter :check_xhr, :preload_json, :verify_authenticity_token
./plugins/discourse-blogger-plugin/plugin.rb:35:#    before_filter :ensure_embeddable, except: [ :info ]
./plugins/discourse-donations/app/controllers/discourse_donations/charges_controller.rb:7:    skip_before_filter :verify_authenticity_token, only: [:create]
./plugins/discourse-layouts/controllers/widget.rb:4:  before_filter :ensure_admin
./plugins/discourse-plugin-permalink/integrate.rb:35:        klass.skip_before_filter :check_xhr, only: [:permalink]
./plugins/discourse-plugin-shared-edit/plugin.rb:59:      before_filter :can_change_share_edit?
./plugins/discourse-qa/plugin.rb:39:    before_filter :check_if_voted, only: :create
./plugins/discourse-reset-bump/plugin.rb:42:    # You'll find other plugins and Discourse code using before_filter instead of
./plugins/discourse-reset-bump/plugin.rb:44:    # makes 'before_filter' deprecated and start causing warnings, and Rails 5.1 will remove
./plugins/discourse-slackdoor/plugin.rb:24:    before_filter :slackdoor_enabled?
./plugins/discourse-slackdoor/plugin.rb:25:    before_filter :slackdoor_username_present?
./plugins/discourse-slackdoor/plugin.rb:26:    before_filter :slackdoor_token_valid?
./plugins/discourse-user-feedback/app/controllers/ratings_controller.rb:4:  before_filter :ensure_topic_existence
./plugins/dl-license-keys/app/controllers/dl_license_keys/license_users_controller.rb:6:    skip_before_filter :check_xhr, only: [:validate]
./plugins/retort/plugin.rb:30:    before_filter :verify_post_and_user, only: :update

Some of these might be obsolete - if so maybe they can be removed from the all-the-plugins repo, and moved to #plugin:broken-plugin to avoid any future confusion.

babble @gdpelican
blog @sam
(official?) discourse-atom-receiver
discourse-blogger-plugin @kcoop
discourse-donations @rimian
discourse-layouts @angus
discourse-plugin-permalink @lightyear
discourse-qa @angus
discourse-reset-bump @LeoDavidson (just a comment)
discourse-slackdoor @mcwumbly
discourse-user-feedback @jafeth.diazc
dl-license-keys @joebuhlig
retort @gdpelican

12 Likes