Why is RTL class user dependent instead of locale?

Mittineague · 11. Dezember 2016 um 08:22

I won’t go so far to say I know the code inside out, but I’ll chip in my

I looked to see if any tests might break if current_user_rtl or site_locale_rtl were removed. I found none and in fact the only place they exist in the Core code is in the models/rtl.rb file.
So removing them might break some plugins if they are using them, but it shouldn’t break Discourse.

I don’t think “i18n” would need to be used in the proposed enabled but I’ve seen it used in other files.

github.com/discourse/discourse

app/services/post_alerter.rb

main


      
            )
          end
          
          def unread_posts(user, topic)
            Post
              .secured(Guardian.new(user))
              .where(
                "post_number > COALESCE((
                       SELECT last_read_post_number FROM topic_users tu

github.com/discourse/discourse

app/services/badge_granter.rb

main


      
            if id.blank?
              unmatched << entry
              next
            end
          
            if ensure_users_have_badge_once
              count_per_user[id] = 1
            else
              count_per_user[id] ||= 0
              count_per_user[id] += 1
            end
          end

github.com/discourse/discourse

app/controllers/application_controller.rb

main


      
                status: 429,
                extras: {
                  wait_seconds: retry_time_in_seconds,
                  time_left: e&.time_left,
                },
                headers: response_headers,
              )
            end
          end
          
          rescue_from Discourse::NotLoggedIn do |e|
            if (request.format && request.format.json?) || request.xhr? || !request.get?

Thema		Antworten	Aufrufe
Digest Emails are not supporting RTL Product Support activity-summary	2	659	26. November 2019
Layout for RTL users can't be set per user, only at the whole site level UX	10	1532	28. Oktober 2019
Emails for rtl languages have ltr direction Bug	19	5121	17. Juni 2017
Setting input direction in UI Feature	1	913	31. März 2017
Recommended way to handle RTL mixed with LTR languages Product Support	30	14514	20. September 2020

Why is RTL class user dependent instead of locale?

Verwandte Themen