Some parameters cause English to appear in localised strings

Contribute Translations

AI-generated summary

The discussion revolves around an issue where some parameters cause English strings to appear in localized versions of Discourse. rizka reported that after updating to version 2.2, the moderator post contains the word “topic” in Finnish, despite it being hardcoded in English.

Additionally, rizka mentioned that the “Category” attribute name is not translated and appears in error prompts. gerhard confirmed that the issue is due to hardcoded values and attribute names not being translated.

gerhard subsequently fixed both issues with commits to the Discourse repository. rizka thanked gerhard and implemented a temporary override for the faulty strings on their stable branch.

1

After updating to 2.2, I split a post into another topic. The moderator post has the word topic in it even though that’s not Finnish.

image
image400×131 4.39 KB

It comes from move_posts.existing_topic_moderator_post. Where is that %{entity} supposed to come from? Seems that it won’t work anyway.

English:

A post was split to a new %{entity}: %{topic_link}

Finnish:

Viesti siirrettiin uuteen %{entity}: %{topic_link}

Furthermore, I got a report that the Uncategorized category is visible to regular users now and they can even try to create topics there. I’m not sure what has changed, though, but clearly something. Anyway, when he tried to create a topic there he couldn’t, because we have prevented that by disabling allow uncategorized topics. The error prompt he received was:

Category on varattu

That one comes from errors.messages.exclusion which is somewhat different as there is not even a parameter in that string. Not sure where the word “Category” comes from. Maybe it’s hardcoded?

3 Likes
2

You are right. “message” or “topic” are hardcoded values for %{entity}. I’m going to fix that.

Yeah, that’s the attribute name that caused the validation error. Most of them aren’t translated. I think it should be enough to add a new translation for activerecord.attributes.category. I’ll see what I can do.

5 Likes
4

Thanks for reporting those issues. I fixed both of them:

4 Likes
5

Thank you!

As we are running the stable branch, I overrode those strings featuring the faulty entity. They will now say the posts were moved into a topic (ketju) even if they would be moved into a message. We can live with that. Especially since I don’t think any post has ever been moved into a message.

3 Likes
6

This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.