martin
June 23, 2025, 1:40am
7
Okay it was a little tricky to untangle, but I think this will correct the issue:
main ← issue/fix-new-user-posting-first-day-logic
opened 01:38AM - 23 Jun 25 UTC
All the way back in bc52bdfa1280ba08e6fb1931c26e18aa7fee9f7f we changed
the def… inition of new_user_posting_on_first_day? to return true if the
user was TL0 unconditionally. However this changes the logic of
the method, and essentially makes it "lie". Yes TL0 may be considered
a new user in other places, but in this method specifically we want
to check it's their "first day" of posting, not just that they are TL0.
The intent per these commits:
* 487c20959c874666db726d69c00abe139ba1aeab
* 5aa1272f05fc0de0b08577707d3370d10fafdd51
* 9834d1150300de26ffc35cb6af9a3ac91666e216
Was consider any user < TL2 who hadn't made their first post yet
as a new user posting on their first day. If they had made a post
>= 24 hours ago, they were no longer considered a new user posting
on their first day.
This commit restores that logic and also cleans up the spec and
guardian check to be clearer.
Basically we changed the intent of new_user_posting_on_first_day? years ago so it didn’t match the description and the errors. This restores the old behaviour and doesn’t treat TL0 users as new users at all times for the purposes of this check.
3 Likes