We previously used an addon to automatically switch themes based on the user’s OS dark mode setting. This was deprecated and is no longer developed, so we tried to switch to this feature. It seems it only switches color schemes, not entire themes, so it won’t work for us. Any thoughts on supporting theme switching? Would love to designate one theme the default light, one the default dark, and have it just work™.

Unfortunately theme switching can’t just work™. [image]Automatic Dark Mode color scheme switching We cannot switch themes on-the-fly, themes can have custom javascript code, and it’s not possible to switch the javascript code without reloading the page.

Out of curiosity, how did the older addon work then? It forced a hard refresh? I was just about to link it when I realized it was actually your addon! https://github.com/pmusaraj/discourse-dark-mode

Yes, it forced a hard refresh, see this line: javascripts/discourse/initializers/dark-mode.js.es6 master setTimeout(function() { // delay and visibilityState check // needed because of a Safari iOS bug // that triggers matchMedia listener // while turning off screen if (document.visibilityState !== "hidden") { currentUser.findDetails().then(user => { const seq = user.get("user_option.theme_key_seq"); themeSelector.setLocalTheme([themeId], seq); showModal("dark-mode-modal"); window.location.reload(); }); } }, 500); } browserInDarkMode.addListener(toggleDarkTheme); var domReady = function(callback) { document.readyState === "interactive" || document.readyState === "complete"

[image] Wingtip: not entire themes, so it won’t work for us I’m curious, what are the features that you absolutely need in a dark theme but not in a light theme?

Makes sense. We were fine with that. Now my users lost a feature they’ve had for years, and they’re pretty upset about it. I would have simply continued using your plugin, but you literally say “Please don’t use it!” in the description, with an exclamation mark and everything. :slight_smile: Re features we need, switching color schemes alone didn’t work for us, pages were ugly. I’m sure the answer is to fix our themes as per the OP in this thread, but we don’t have anyone to actually do that. Is it still safe to use your plugin, exclamation mark notwithstanding?

[image] Wingtip: Is it still safe to use your plugin, exclamation mark notwithstanding? :slight_smile: well… I’m pretty sure I added the exclamation mark, so I’d say, no, it’s not safe. It might still work, but the last commit to that code was in 2020.

OK, thanks. Anyway, just one admin here saying we found that functionality useful and now miss it.

[image] Wingtip: I’m sure the answer is to fix our themes as per the OP in this thread, but we don’t have anyone to actually do that. How about #marketplace?

The site isn’t exactly a money-making endeavor, just an ancient forum with an enduring community over the decades.

Autotomatic Dark Mode only changes colour palette, not theme

Product Support

pmusaraj (Penar Musaraj) June 23, 2023, 7:55pm 7

well… I’m pretty sure I added the exclamation mark, so I’d say, no, it’s not safe. It might still work, but the last commit to that code was in 2020.

Topic		Replies	Views
Automatic Dark Mode color scheme switching Announcements new-feature , auto-dark	24	18987	December 7, 2021
How to make the automatic dark theme the same as the selected dark theme? Product Support dark-theme , dark-mode-toggle	10	823	December 14, 2024
Theme idea: Toggle selector for light or dark theme in header row Feature	4	1523	June 1, 2020
Support `prefers-color-scheme` CSS media query Feature	9	2494	December 10, 2022
Automatic Night Mode Plugin Feature	13	2315	April 23, 2019

Autotomatic Dark Mode only changes colour palette, not theme

Related topics