No criticism of this PR (I didn’t look at it in detail), but in general I can’t think this is good practice.
- you will get no updates from core whilst you are stuck on this branch, that includes any security patches.
- you may get some instability from changes in the branch (which has to be treated as development code until merged)
- what do you do if it’s rejected?
- heck the tests haven’t even run yet?
Take advantage of CDCK developer review and wait til it’s reviewed & merged?