Topic link counter stops at 50

Richie · 3월 29, 2025, 9:47오전

Discourse 3.5.0.beta3-dev (afde7cc172).

The link counter displayed at the bottom of a topic seems to stop at 50, even when there are over 1,000 links in the thread:

For reference:

On another topic, this one also says 50:

When there are 250+ links:

Does anyone know what might be causing this?

pfaffman · 3월 29, 2025, 9:41오후

Without looking at the code, I think that number probably comes from topic_links, so something like

select * from topic_links where topic_id=1234

It does seem like a bug, though.

Richie · 3월 30, 2025, 10:09오전

Interesting, hadn’t spotted that table.

If this helps, there are 4,155 links in this topic id yet it says 50x on the front end:

pfaffman · 3월 30, 2025, 2:45오후

~~Sounds like a bug. Maybe share the link. Maybe look in the code.~~

Looks like it’s limited to 50 on purpose; I guess that it’s a complicated join and having it do hundreds or thousands would be a performance issue.

github.com/discourse/discourse

app/models/topic_link.rb

main


      
          def self.topic_map(guardian, topic_id)
            # Sam: complicated reports are really hard in AR
            builder = DB.build(<<~SQL)
              SELECT ftl.url,
                     COALESCE(ft.title, ftl.title) AS title,
                     ftl.link_topic_id,
                     ftl.reflection,
                     ftl.internal,
                     ftl.domain,
                     MIN(ftl.user_id) AS user_id,
                     SUM(clicks) AS clicks
              FROM topic_links AS ftl
              JOIN posts AS source_posts ON ftl.post_id = source_posts.id
              LEFT JOIN topics AS ft ON ftl.link_topic_id = ft.id
              LEFT JOIN categories AS c ON c.id = ft.category_id
              LEFT JOIN posts AS target_posts ON ftl.link_post_id = target_posts.id
              /*where*/
              GROUP BY ftl.url, ft.title, ftl.title, ftl.link_topic_id, ftl.reflection, ftl.internal, ftl.domain
              ORDER BY clicks DESC, count(*) DESC

Richie · 3월 30, 2025, 3:44오후

흠

확인해 주셔서 감사합니다 @pfaffman

전혀 부정확한 숫자를 최종 사용자에게 표시해야 하는 이유를 모르겠어요

정보가 없는 것이 부정확한 정보보다 낫습니다.

이 잘못된 숫자를 완전히 제거하지 않고도 적용할 수 있는 간단한 해결책이 하나 있습니다.

Contribute > UX 채널에 제안을 올려볼게요

sam · 3월 31, 2025, 5:41오전

Yeah this lives between bug and ux.

On one hand it only impacts the UI of Discourse, on the other hand it is buggy to show a number that we know is not correct.

I think the simplest fix on our side is to select 51 and then show the text “50+” in the UI if we get 51.

It feels in the realm of pr-welcome, but I will leave @lindsey to triage and decide.

sam · 3월 31, 2025, 5:43오전

Oh I see:

So I guess we take it up there.

글		댓글	조회수
Suggestion for fixing the inaccurate link counter value UX fixed	11	362	4월 30, 2025
Linkify more than 50 URLs Support	1	474	2월 8, 2023
Limited amount of Oneboxes for a post? Support onebox	12	548	1월 14, 2024
Links generated by "link summary" feature count towards link count Bug onebox	2	992	11월 7, 2015
Topic-map-summary only shows the likes of the first post Bug	4	1216	4월 6, 2016

Topic link counter stops at 50

Related topics