Allow the ability to Edit post on rejection

When your post gets rejected by a staff this is the message that is shown

Hi [user],

We’ve reviewed your new topic titled “[topic titles]” and have some feedback for you.

Reason: N/a

Feedback: This is what it shows when your post is given feedback

You can edit your topic’s original post below and re-submit to make the suggested changes, or reply to this message if you have any questions.

But you cant actually edit the post because nothing appears below it
this is a picture of the PM that is sent to this test user after they created a post that needed approval of it and it was rejected with a revision

and there is nothing there to edit below
So my request is that discourse adds the ability to actually edit the post itself on the PM and then it autoresubmits the post there for you on the forum and then the mods can re-reveiw it

2 Likes

Good catch! I moved this to UX because it relates to language in the interface.

I searched through my moderator PMs and found a similar one. Looking at your screenshot and copied text from the PM, the part that is written by the user being given feedback is “test post for meta topic here”. The rest of it is in the template.

The instruction is confusing because, as you say, you can’t edit the post “below”. To edit it, you would go back to the topic and edit it there. Or you reply to talk about it with moderators.

I don’t think that change is going to be possible because it makes the UI too complicated.

I think the answer here will be to improve the instruction like this:

You can edit your post to make the suggested changes, or reply to this message if you have any questions.

We can also provide a link to the actual post to make it easier to get back to.

1 Like

that would work as well but the thing is once the moderators reject the post It no longer can be edited it sends the Pm but then they need to go back and recreate the post.

Furthermore I think maybe if it created a reply or a draft in your account draft pages to remake the post with the title there and then you resubmit that

let me know if that makes sense

additionally adding the link would mean that rejecting the post couldn’t delete it because then they can’t go and assess their post again?

Oh, I see. The review queue is just providing a copy of the (now deleted) post for convenience for the user, so they can copy it into a new post and improve it there. That makes it even easier:

Your post has been deleted but a copy is provided below for your convenience. Please post it again with the suggested changes, or reply to this message if you have any questions.

1 Like

Being able to edit the pending ‘post/topic’ [1] would be great though, and would really smooth out this experience for users. I think there was some talk of this in the past.

Currently the pending posts show in the post stream as well as in your /activity/pending(that page has both pending posts and topics), but you can only delete and not revise them. If they could be made editable in a similar way as the review queue allows admin/moderators to then handling the approval with ‘Revise’ could avoid deleting it and allow it to remain as ‘pending’. The feedback PM could then have a link to make it easy to navigate to, edit, and resubmit. :magic_wand:

There may be some rough edges to smooth out to prevent editing by user and mod at the same time, but maybe some of the new auto reviewable claiming could help with that and provide an edit lock.

There would also need to be some allowance made for the Reviewable after it had been handled as Revise, as theoretically the flag would have been handled, but would also still be pending. (And you perhaps wouldn’t want that sitting as a live flag in your review queue while you wait for an indeterminate amount of time for the revision, which may never come). :thinking:


  1. I don’t think it’s actually a post/topic at this point, but rather a precursor ↩︎

3 Likes

I think the new changes being worked on in the review queue will allow assigning flagged items to other people.. maybe in this case it could be assigned back to the user who posted it?

I think a system that can allow for the real possibility of ‘abandonment’ may be needed. So something that can self-tidy after a reasonable timeframe.

Possibly something clever like the original pending item being deleted but immediately replaced with a duplicate so it looks exactly the same to the user but can then create a new reviewable in the queue when resubmitted.

Possibly also a delete-timer in a similar fashion to Delete removed posts after (with a more reasonable ‘revision time window’ than 24 hours)

Not really though if the user who’s post got rejected with the feedback may not be around to view the rejection then comes around 2 days later the 24 hour deletion timer would have not let them come back to edit it and this may cause some issues in different forums?
Perhaps its auto set to 24 hours maybe and then in something in the admin dashboard they can change the auto timer?

1 Like

Ah, sorry for the confusion. I was referring to the default for the existing Delete removed posts after admin setting being 24 hours, and that while a similar function could also be applied here to ensure pending posts were not sticking around forever it would need a much more generous time window.

1 Like

So then it would make them a PM with it?

including the timer?

?afterwords they can edit there and resubmit

Hmm. Not really. Though if the product team are interested in the idea, and the dev team think that’s the best way to implement it then I’m not against it. :slight_smile:

But in my mind it would stay as a pending ‘item’ and be editable from your /pending page (with at least the appearance of it being a post/topic). The PM you receive on ‘Revise’ would ostensibly be the same as now but with a link directing you to where the pending item can be edited, and a generic ‘you have {30 days} to revise and resubmit your contribution before it’s automatically deleted’ (or some such)

that actually is a good idea makes the most sense
but wouldn’t it really mess up the UX for the hole rework of the Reviw and add the newest addition with the message? @JammyDodger

I mean, a lot of this is just ideas and the dev team [1] could well say that the picture I have in my mind is not the best way/is just simply unworkable. :slight_smile:

But I think if the first pending item is treated as its own entity (that is, the flag is handled, a PM is sent, the reviewable is no longer pending) and a second, duplicate pending entity is created to allow for editing and resubmitting then it could then be popped in the approval queue as a ‘new’ reviewable once resubmitted. The pending item awaiting revision could be marked clearly as such on the /pending page as well to reduce confusion (is it waiting for mod approval/is it waiting for me to revise?)


  1. (if they ever pick the feature up to work on) ↩︎

But where would the second go? how would one change the second for review again or suppose they leave out the watched word?

I’m not 100% sure I understand the question, but I was thinking of a flow something like this:

flowchart TD
    A[Post/Topic Created] --> B[Pending in Approval Queue]
    B --> C[Revise]
    C --> D[Pending Awaiting Revision]
    D --> E[Resubmit]
    E --> B[Pending in Approval Queue]
    
    B --> H[Approve Post/Topic] --> I[Published to Site]
    B --> F[Reject Post/Topic] --> G[Deleted]

    style F fill:#ff4c4c,stroke:#000,stroke-width:2px
    style H fill:#4caf50,stroke:#000,stroke-width:2px

So any second/third/fourth revisions would loop round (and a mod could call time manually when enough was enough :slight_smile: )

I think I envisage the ‘Revise’ option being used in cases where there is a higher likelihood of receiving a better version (so anything that doesn’t hit that threshold wouldn’t be sent back for revision in the first place)

2 Likes

Ok that makes more sense but suppose we added a setting for the multiple revision called post rejected reviews delte where admins set after (x) revision denies it removes the post automatically to prevent :infinity: times of revision?