合并的主题不再被顶起

christo · 2025 年10 月 23 日 16:18

这是修复此问题的 PR。一旦获得批准和合并，我会再次更新。

github.com/discourse/discourse

FIX: Moving first post sequentially doesn't bump the destination topic

main ← fix/move-newer-post-should-bump

opened 09:28PM - 22 Oct 25 UTC

nullchristo

+117 -19

Fixes a bug I introduced in #35373. Reported on Meta /t/386078 The intention …there was to make sure that when merging a first post from one topic which is older than the latest post in the destination topic, we shouldn't bump the destination topic. Previous to that, we were bumping the destination topic to the date of the moved post, which sometimes pushed the bumped_at timestamp back in time. Looks like that also broke the case where the moved first post is more recent than the latest post in the destination topic, because the logic for updating the bumped_at date based on the most recent merged post (in `update_last_post_stats`) wasn't considering moved posts which were the first post of their original topic because the `id` of that post has changed. This should fix both cases. Now if any post moved (including a first post) is newer than the latest post in the destination topic, the destination topic should be bumped. Post timings should still be respected. Adds test cases for chronological and sequential moves of first posts which become the newest post in the destination topic, and updates a test to make sure I didn't break post timings.

话题		回复	浏览量
Moving posts into an existing topic doesn't keep chronology Feature completed	44	10048	2023 年6 月 14 日
It's very surprising for "merge topics chronologically" to replace the first post of the target existing topic! Feature	6	434	2023 年7 月 10 日
Unable to merge Posts/Topics with Banner Topic Bug	1	200	2024 年1 月 24 日
Move later post to another topic: shouldn't it bump the topic up the list? Feature	17	1283	2018 年2 月 22 日
Topic unlisted to all users including admins after merging topics Support	3	88	2025 年6 月 28 日

合并的主题不再被顶起

相关话题