تجربة تكنوبلوج مع تعليقات ديسكورش

Falco · 16 أبريل 2026، 5:35م

شكراً لك على الاختبار، تم العثور على المشكلة

github.com/discourse/discourse

FIX: Use iframe style.height for embed resize messages (#39321)

main ← fix/embed-dynamic-height-inline-style

merged 06:17PM - 16 Apr 26 UTC

xfalcox

+1 -1

## Summary When Discourse is loaded in full app embed mode with `dynamicHeight:… true`, the iframe was not resizing in production despite `discourse-resize` messages arriving correctly. The full app path sets `iframe.style.height` as an inline style for the initial height. Inline styles always win over the `height` HTML attribute, so our resize handler — which set `iframe.height = ...` — had no visible effect. This changes the resize handler to set `iframe.style.height` so it actually overrides the inline style. This also works for the standard (non-full-app) embed path since no inline style is set there initially. ## Test plan - [ ] Full app embed with `dynamicHeight: true` — verify iframe height updates as content loads - [ ] Standard (non-full-app) embed — verify iframe still resizes correctly - [ ] CSS `max-height` on the iframe still wins (inline `height` doesn't override `max-height`)

الموضوع		الردود	مرات العرض
Embed Discourse comments on another website via Javascript Integrations embedding , how-to	127	306872	2 يونيو 2026
Embed Discourse comments with on-page commenting? Feature	32	8540	19 يناير 2019
Embed Discourse as a full comment system on your site Announcements embedding	27	3363	10 أكتوبر 2026
Discourse Comments stuck on "Loading..." Product Support	22	2440	18 سبتمبر 2024
Should Discourse make an effort to become a viable comment platform? Community Building	62	6145	25 مارس 2026

تجربة تكنوبلوج مع تعليقات ديسكورش

الموضوعات ذات الصلة