Tecnoblog's Experience With Discourse Comments

Falco · April 16, 2026, 5:35pm

Thanks for testing, found the issue

github.com/discourse/discourse

FIX: Use iframe style.height for embed resize messages (#39321)

main ← fix/embed-dynamic-height-inline-style

merged 06:17PM - 16 Apr 26 UTC

xfalcox

+1 -1

## Summary When Discourse is loaded in full app embed mode with `dynamicHeight:… true`, the iframe was not resizing in production despite `discourse-resize` messages arriving correctly. The full app path sets `iframe.style.height` as an inline style for the initial height. Inline styles always win over the `height` HTML attribute, so our resize handler — which set `iframe.height = ...` — had no visible effect. This changes the resize handler to set `iframe.style.height` so it actually overrides the inline style. This also works for the standard (non-full-app) embed path since no inline style is set there initially. ## Test plan - [ ] Full app embed with `dynamicHeight: true` — verify iframe height updates as content loads - [ ] Standard (non-full-app) embed — verify iframe still resizes correctly - [ ] CSS `max-height` on the iframe still wins (inline `height` doesn't override `max-height`)

Topic		Replies	Views
Embed Discourse comments on another website via Javascript Integrations embedding , how-to	123	302075	October 27, 2025
Embed Discourse comments with on-page commenting? Feature	32	7995	January 19, 2019
Discourse Comments stuck on "Loading..." Support	22	2105	September 18, 2024
How to automatically adjust iframe height for embedded wordpress posts WordPress	18	4927	June 26, 2025
Should Discourse make an effort to become a viable comment platform? Community Building	63	4833	March 25, 2026

Tecnoblog's Experience With Discourse Comments

Related topics