Hello! I have a question that I’m hoping someone can help me answer. I have recently begun embedding for more than one site on my instance ( pixls.us and digikam.org ). I’m wondering if there’s a way to differentiate which host is being embedded in for styling? One site is white background and the…

Perhaps adding another parameter to DiscourseEmbed that we can specify, like a discourseEmbedClass that we can then attach to the iframe/embedded tag as a class, so we can target it with the embed CSS? DiscourseEmbed = { discourseUrl: 'http://discuss.pixls.us/', discourseEmb…

I was playing around with the embed stuff the other day. You’re interested in public/javascripts/embed.js, and adding an additional query parameter to queryParams based on DE.discourseEmbedClass, which you could then set in the embedded code.

Why don’t you just style the embedded iframe from your sites’ css?

[图片] kraml: Why don’t you just style the embedded iframe from your sites’ css? It’s not possible to modify the iframe from the parent (particularly cross domain). Unless I’ve missed something?

Yes that’s right. But I saw you mentioned about background color particularly. You can style the background color of the outer div of the iframe, which is part of your website not discourse. And your embedded iframe will get that background color. I did that on my site. Edit: I read your OP too qui…

At the moment, my idea is to attach the discourseEmbedClass idea as a class to the embedded <html> element (basically, <html class='SOME-CLASS-PARAM'>) so the CSS can target this element w/o hacking at the actual embed code.

Well, I’ve made some headway, but could use a pointer if anyone is up for a little help. I can pass the param to the /javacripts/embed.js. My problem now is getting it to the iframe. Trying to set the iframe <html> element during creation gets wiped out when iframe.src is set. Checking the sourc…

Ok, created PR for this. Hopefully it works and gets merged! https://github.com/discourse/discourse/pull/4850

I believe a better approach would be to: Update the embeddable_host table to add a custom class attribute Update the admin UI to allow input in that field Update the embed erb template to show that custom value I have security concerns otherwise with passing the value through on the client side. …

Sweet merciful goodness I think I have something working. I have added the necessary column to :embeddable_hosts and updated the admin UI for inputting that field. (I am not sure what the naming convention for this file should be, I went with 20170505_add_embed_class_name_to_embeddable_hosts.rb). …

Embedding in more than one host

Development

Patrick_David (Pat David) 2017 年5 月 8 日 17:58 14

With the help of @darix we’ve got a PR that works on my tests here using the embeddable_hosts model (per @eviltrout).

https://github.com/discourse/discourse/pull/4857

话题		回复	浏览量
Style Embeds in Multiple Hosts Administrators how-to	0	1844	2017 年5 月 15 日
Embed Discourse comments on another website via Javascript Integrations embedding , how-to	127	306575	2026 年6 月 2 日
How to customize appearance of discourse embeds? Product Support	4	1359	2022 年10 月 6 日
"Error Embedding" comments Product Support	16	2515	2022 年5 月 4 日
Automatic dark mode for embedded comments as well? Feature embedding	17	2508	2024 年11 月 6 日

Embedding in more than one host

相关话题