A comma followed by an underscore in a URL results in defunct link

markdown-it-review

(Adrelanos) #1

<a href="https://www.whonix.org/wiki/Comparison_Of_Tor_with_CGI_Proxies,_Proxy_Chains,_and_VPN_Services#Comparison_of_Tor_and_VPN_services">here</a>

results in:

here

https://www.whonix.org/wiki/Comparison_Of_Tor_with_CGI_Proxies,%3Cem%3EProxy%3C/em%3EChains,%3Cem%3Eand%3C/em%3EVPN_Services#Comparison_of_Tor_and_VPN_services

It adds extra <em> after the comma.

Not great to have , inside links indeed, but I perhaps this could be fixed anyhow?


(Kevin P. Fleming) #2

Spaces are not allowed in URLs, they are supposed to be URL-encoded. Commas should be URL-encoded as well. How did you obtain a URL with embedded commas and spaces?


(Jakob Borg) #3

Both commas and underscores (which I think is the problematic character here) are perfectly fine in URLs. The comma is a reserved character so may be percent escaped to avoid it being interpreted in a reserved manner by the server, but the client shouldn’t care either way.

In this case it looks like the markdown parser is looking too deep into the tag…


(Tomas Ibarra) #7

And how is the URL supposed to be @adrelanos?


(Sam Saffron) #8

Logic is in a nasty regex that I do not want to hack on, we get a brand new regex with the new markdown engine, this fix will have to wait till then


(Sam Saffron) #9

This now works, for added bonus it also auto links correctly.


(Sam Saffron) #10