A «Title can't have more than 1 emoji» false positive

(Discourse.PRO) #1

The title is «What is the difference between Mage::getSingleton() and Mage::getModel() in Magento?»

(Jeff Atwood) #2

I see, is it detecting those crazy quotes as emoji? That’s one for you @techapj perhaps?

(Joffrey Jaffeux) #3

That should fix it @techAPJ FIX: do not treat :: as a valid emoji by jjaffeux · Pull Request #5647 · discourse/discourse · GitHub I let your review/merge it.

As a side note any :string: would be considered an emoji, I feel like we shouldn’t over-engineer it and just keep going with the simple regex we have. If it would become an issue, we could match this against our list of emojis, given it only happen in validation it wouldn’t be that bad.

(Arpit Jalan) #4

Looks good to me, merged. :+1:

Sounds good, let’s see if it comes to that.

(Arpit Jalan) #5

This topic was automatically closed after 21 hours. New replies are no longer allowed.