A «Title can't have more than 1 emoji» false positive

bug
1

01
01.png728×278 5.89 KB

The title is «What is the difference between Mage::getSingleton() and Mage::getModel() in Magento?»

3 Likes
2

I see, is it detecting those crazy quotes as emoji? That’s one for you @techapj perhaps?

2 Likes
3

That should fix it @techAPJ https://github.com/discourse/discourse/pull/5647 I let your review/merge it.

As a side note any :string: would be considered an emoji, I feel like we shouldn’t over-engineer it and just keep going with the simple regex we have. If it would become an issue, we could match this against our list of emojis, given it only happen in validation it wouldn’t be that bad.

6 Likes
4

Looks good to me, merged. :+1:

Sounds good, let’s see if it comes to that.

7 Likes
5

This topic was automatically closed after 21 hours. New replies are no longer allowed.