Account creation not working with discourse_encrypt

Bug
1

Hello,

Since I first, second updated yesterday the registration not working.

When I click the Create your account button in create-account modal then I get an alert error top of the modal:

Something went wrong, perhaps the username or email is already registered. Try the forgot password link.

Which is not true because I tried with new email and username… and the field validations are also accepted.

I also have two required confirmation user field if that means something.

I tried it with safe mode and rebuild etc… Nothing worked.
No error in console or /logs.

One more thing I changed yesterday is add the following to clean up old assets :arrow_down_small:
(I use Digital Ocean Spaces)

But this is run successfully when I rebuild or update.

Here is the site. Where you can check it.

Any help or idea would be appreciated! Thank you :slightly_smiling_face:

1 Like
2

I’ve just tried to register and I also get an error (though running it through translation I get ‘Something went wrong! Registration is currently under maintenance! Please come back later and try again.’[1])

It works here on Meta, so that may help narrow it down. I’ll try and see if I can break my test site with some custom fields, etc. :+1:

  1. Valami hiba történt! A regisztráció jelenleg karbantartás alatt van! Kérlek, látogass vissza kicsit később és próbáld újra. ↩︎

1 Like
3

Thanks for checking :slightly_smiling_face: Yeah I just rewrite the default error message to warn the users the issue is our side. Sorry I forget to mentioned it. :confused:

But this message is the: login.something_already_taken

1 Like
4

I tried to register with invite and it dropped me finally an Internal Server Error :slightly_smiling_face:

With the following error in /logs

Screenshot 2022-11-23 at 11.05.09
Screenshot 2022-11-23 at 11.05.091434×94 11.6 KB

Info 
ActiveRecord::NotNullViolation (PG::NotNullViolation: ERROR:  null value in column "encrypt_pms_default" of relation "user_options" violates not-null constraint
DETAIL:  Failing row contains (5333, f, t, t, t, f, t, 10080, 300000, 2880, null, 2, f, 1, 1, f, 2, 0, t, null, {}, f, 0, 0, 1, 0, 0, f, null, f, null, f, null, 0, null, t, null, null, null, null, 3, null, 1, f, null, 0, null).
)
app/models/user.rb:1734:in `create_user_option'
app/models/invite_redeemer.rb:142:in `create_user_from_invite'
app/models/invite_redeemer.rb:208:in `invited_user'
app/models/invite_redeemer.rb:260:in `add_user_to_groups'
app/models/invite_redeemer.rb:226:in `process_invitation'
app/models/invite_redeemer.rb:55:in `block in redeem'
app/models/invite_redeemer.rb:53:in `redeem'
app/models/invite.rb:227:in `redeem'
app/controllers/invites_controller.rb:227:in `perform_accept_invitation'
app/controllers/application_controller.rb:413:in `block in with_resolved_locale'
app/controllers/application_controller.rb:413:in `with_resolved_locale'
lib/middleware/omniauth_bypass_middleware.rb:71:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:368:in `call'
config/initializers/008-rack-cors.rb:25:in `call'
config/initializers/100-quiet_logger.rb:23:in `call'
config/initializers/100-silence_logger.rb:31:in `call'
lib/middleware/enforce_hostname.rb:23:in `call'
lib/middleware/request_tracker.rb:202:in `call'
Backtrace 
rack-mini-profiler (3.0.0) lib/patches/db/pg.rb:69:in `exec_params'

rack-mini-profiler (3.0.0) lib/patches/db/pg.rb:69:in `exec_params'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql_adapter.rb:768:in `block (2 levels) in exec_no_cache'

activesupport (7.0.3.1) lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'

activesupport (7.0.3.1) lib/active_support/dependencies/interlock.rb:41:in `permit_concurrent_loads'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql_adapter.rb:767:in `block in exec_no_cache'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract_adapter.rb:765:in `block in log'

activesupport (7.0.3.1) lib/active_support/notifications/instrumenter.rb:24:in `instrument'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract_adapter.rb:756:in `log'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql_adapter.rb:766:in `exec_no_cache'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql_adapter.rb:745:in `execute_and_clear'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql/database_statements.rb:54:in `exec_query'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/database_statements.rb:132:in `exec_insert'

activerecord (7.0.3.1) lib/active_record/connection_adapters/postgresql/database_statements.rb:92:in `exec_insert'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/database_statements.rb:167:in `insert'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/query_cache.rb:22:in `insert'

activerecord (7.0.3.1) lib/active_record/persistence.rb:496:in `_insert_record'

activerecord (7.0.3.1) lib/active_record/persistence.rb:1096:in `_create_record'

activerecord (7.0.3.1) lib/active_record/counter_cache.rb:166:in `_create_record'

activerecord (7.0.3.1) lib/active_record/locking/optimistic.rb:79:in `_create_record'

activerecord (7.0.3.1) lib/active_record/attribute_methods/dirty.rb:222:in `_create_record'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:461:in `block in _create_record'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:107:in `run_callbacks'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:929:in `_run_create_callbacks'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:461:in `_create_record'

activerecord (7.0.3.1) lib/active_record/timestamp.rb:108:in `_create_record'

activerecord (7.0.3.1) lib/active_record/persistence.rb:1067:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:457:in `block in create_or_update'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:107:in `run_callbacks'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:929:in `_run_save_callbacks'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:457:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/timestamp.rb:126:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/persistence.rb:648:in `save!'

activerecord (7.0.3.1) lib/active_record/validations.rb:53:in `save!'

activerecord (7.0.3.1) lib/active_record/transactions.rb:302:in `block in save!'

activerecord (7.0.3.1) lib/active_record/transactions.rb:354:in `block in with_transaction_returning_status'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/database_statements.rb:314:in `transaction'

activerecord (7.0.3.1) lib/active_record/transactions.rb:350:in `with_transaction_returning_status'

activerecord (7.0.3.1) lib/active_record/transactions.rb:302:in `save!'

activerecord (7.0.3.1) lib/active_record/suppressor.rb:54:in `save!'

activerecord (7.0.3.1) lib/active_record/persistence.rb:55:in `create!'

app/models/user.rb:1734:in `create_user_option'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:400:in `block in make_lambda'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:236:in `block in halting_and_conditional'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:599:in `block in invoke_after'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:599:in `each'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:599:in `invoke_after'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:108:in `run_callbacks'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:929:in `_run_create_callbacks'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:461:in `_create_record'

activerecord (7.0.3.1) lib/active_record/timestamp.rb:108:in `_create_record'

activerecord (7.0.3.1) lib/active_record/persistence.rb:1067:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:457:in `block in create_or_update'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:118:in `block in run_callbacks'

activerecord (7.0.3.1) lib/active_record/autosave_association.rb:370:in `around_save_collection_association'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:127:in `block in run_callbacks'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:138:in `run_callbacks'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:929:in `_run_save_callbacks'

activerecord (7.0.3.1) lib/active_record/callbacks.rb:457:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/timestamp.rb:126:in `create_or_update'

activerecord (7.0.3.1) lib/active_record/persistence.rb:648:in `save!'

activerecord (7.0.3.1) lib/active_record/validations.rb:53:in `save!'

activerecord (7.0.3.1) lib/active_record/transactions.rb:302:in `block in save!'

activerecord (7.0.3.1) lib/active_record/transactions.rb:354:in `block in with_transaction_returning_status'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/database_statements.rb:314:in `transaction'

activerecord (7.0.3.1) lib/active_record/transactions.rb:350:in `with_transaction_returning_status'

activerecord (7.0.3.1) lib/active_record/transactions.rb:302:in `save!'

activerecord (7.0.3.1) lib/active_record/suppressor.rb:54:in `save!'

app/models/invite_redeemer.rb:142:in `create_user_from_invite'

app/models/invite_redeemer.rb:208:in `invited_user'

app/models/invite_redeemer.rb:260:in `add_user_to_groups'

app/models/invite_redeemer.rb:226:in `process_invitation'

app/models/invite_redeemer.rb:55:in `block in redeem'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'

activesupport (7.0.3.1) lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction'

activerecord (7.0.3.1) lib/active_record/connection_adapters/abstract/database_statements.rb:316:in `transaction'

activerecord (7.0.3.1) lib/active_record/transactions.rb:209:in `transaction'

app/models/invite_redeemer.rb:53:in `redeem'

app/models/invite.rb:227:in `redeem'

app/controllers/invites_controller.rb:227:in `perform_accept_invitation'

actionpack (7.0.3.1) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'

actionpack (7.0.3.1) lib/abstract_controller/base.rb:215:in `process_action'

actionpack (7.0.3.1) lib/action_controller/metal/rendering.rb:53:in `process_action'

actionpack (7.0.3.1) lib/abstract_controller/callbacks.rb:234:in `block in process_action'

activesupport (7.0.3.1) lib/active_support/callbacks.rb:118:in `block in run_callbacks'

app/controllers/application_control

Which is probably related with Discourse Encrypt (for Private Messages) plugin it was an update 12 days ago so when I first updated the site yesterday this is also updated.
This plugin is installed on my site but is disabled. I try to comment out in app.yml and see how it works. :slightly_smiling_face:

2 Likes
5

I can replicate that now. :+1:

I also have encrypt on my test site, but it was enabled. If I disable it then my test user registrations kick up errors.

2 Likes
6

That is a great news :slightly_smiling_face: I just rebuild now but now I have calmed down :smiley: Thanks Jammy :slightly_smiling_face: Can you move it to bug?

1 Like
7

Unfortunately it is not working yet for me after rebuild without the plugin. Maybe that is not enough… :person_shrugging:

8

When I toggle it off it breaks, but when I toggle it back on it works again. I think you may need to reinstall it and turn it on while a fix is worked on?

1 Like
10

I wonder what the idea is behind having plugins modify the columns of core tables instead of using the plugin_store_rows table or dedicated discourse_pluginname_function tables.

IMO it always ends in tears (or in Sams words: “a bit of a nightmare”) and complex problems.

5 Likes
11

This seems to works :+1: Thanks! :slightly_smiling_face:

1 Like
12

Wow. Or a user_custom_field. That’s surprising indeed.

15

Just wanted to say thanks for the report @Don, we are working on a fix for this and should have one shortly.

Update: a fix is in the works FIX: allow encrypt_pms_default to be null by lis2 · Pull Request #231 · discourse/discourse-encrypt · GitHub, it should be merged shortly.

5 Likes
16

I updated today and now it works great if I disable the plugin. I didn’t try to remove it and rebuild yet but I am sure that will work too. Thanks so much for the fix! :slightly_smiling_face:

2 Likes