Adding links in user fields will automatically convert to HTML tag

[iamntz (Ionuț Staicu)]

Couple of weeks old issue, also present here, on Meta: adding an URL inside a user field will automagically convert it to escaped HTML tag.

[maiki]

Hi @iamntz.

I’ve reproduced this in the Location field, but not with other, custom user fields. Wanted to see if you had experienced this in another field.

[iamntz (Ionuț Staicu)]

There are a couple of screenshots here: ⚠ Raportați problemele întâmpinate pe forum! - #91 de Cosmin_Popescu - Meta - DevForum.ro

Basically the problem is there for any custom field that contains a link.

[JammyDodger]

I have just given it a run-through on my test site and can replicate it happening in a user custom field too:

(I added the emoji using my phone)

[maiki]

It is only happening in the default “Location” field for me, 2.9.0.beta7( 0760b249ff ).

I tried saving an emoji as well, but upon saving and refreshing the page, only the Location field is exploding the URL.

<a href="https://meta.discourse.org/" class="onebox" target="_blank" rel="noopener nofollow ugc">https://meta.discourse.org/</a>

It appears to be one-boxing, so that’s a hint.

[nbianca (Bianca)]

I fixed the issue in this PR:

FIX: Don't cook user fields to apply watched words

It will be merged shortly after review.

[ti0]

@maiki @nbianca just want to add that it is happening on our forum for any link:

[maiki]

Hi @ti0.

Is this a recent regression? Have you updated to the latest version that includes Bianca’s fix?

[ti0]

I believe it is recent. We have not applied that fix yet. We are on 2.9.0.beta7 and that is the latest release available. I will check with the dev responsible if we can check that patch.

[iamntz (Ionuț Staicu)]

@nbianca 's fix works great.

It’s not retroactive though, so if you have those fields messed up, you need to actually clean those manually.