Advertising Plugin for Discourse - Serve Ads on your Discourse Forum (Official Endorsed)

Vaping_Community · 2018-05-16 18:23:57 UTC

Here’s what I use to get the Ads to behave…

.google-adsense.adsense-post-bottom {
    padding: 0 52px;
}

pradeepkumar · 2018-05-16 19:37:19 UTC

Can you kindly share the link to the forum where I can see this live? Would love to implement this on our forum as well. Thank you!

codinghorror · 2018-05-16 19:51:17 UTC

We have looked at this and we believe it is a bug on Google’s side at the moment. @falco where would we report that to Google?

jomaxro · 2018-05-16 21:26:37 UTC

In the meantime we managed to work around a conflict between one Discourse’s libraries and the updated DFP script. Update the plugin and you should be good to go.

Vaping_Community · 2018-05-17 11:23:47 UTC

Its live at vapingcommunity.co.uk

abrambailey · 2018-05-17 22:16:52 UTC

Mine says it’s up to date, but haven’t updated it ever

jomaxro · 2018-05-17 22:22:50 UTC

Hmm…I’m not sure what commit that is you’re on. Do you have root access to the server? Can you share the git clone line for the adplugin from your app.yml? (Just the line, don’t share the entire file it has passwords in it.)

abrambailey · 2018-05-17 22:31:40 UTC

So sorry about that @jomaxro, turns out we’d forked it for some reason and forgotten.

lkramer · 2018-05-18 13:53:24 UTC

This fixed our issue with DFP ads. Thanks very much!

abrambailey · 2018-05-18 14:04:37 UTC

Us too, thanks @jomaxro for the prompt action on this. Our advertising partners appreciate it

heptoilabas · 2018-05-21 08:53:26 UTC

Hello,

I have the same issue even with the last version of everything:

Is anybody else still have the ads not showing?

jomaxro · 2018-05-21 15:09:41 UTC

@heptoilabas our customers running the plugin (who first reported this to us) have that the issue was resolved with our fix, and we’ve not received any further reports thus far.

abrambailey · 2018-05-21 15:10:26 UTC

Currently working for me… I suspect this may be an issue on the DFP configuration or on the DFP side itself.

Nara_Cruz · 2018-05-27 01:07:16 UTC

I have DFP working great but wanted to know if it is possible to serve a particular ad on a specific category or sub-category page?

I’ve set up the key-values in the Discourse Admin:

and in the DFP Line Item but not sure how Discourse will determine a key-value like category=tools in a specific category.

Thanks in advance.

neil · 2018-05-28 13:55:56 UTC

The category is sent to DFP for targeting as “discourse-category”, so you should be able to use it in your DFP configuration.

github.com

discourse/discourse-adplugin/blob/master/assets/javascripts/discourse/components/google-dfp-ad.js.es6#L227


  if (!this.get('showAd')) { return; }


  const ember_w_function = String.prototype.w;
  String.prototype.w = null;
  var self = this;
  loadGoogle(this.siteSettings).then(function() {
    self.set('loadedGoogletag', true);
    window.googletag.cmd.push(function() {
      let slot = defineSlot(self.get('divId'), self.get('placement'), self.siteSettings, self.site.mobileView);
      if (slot && slot.ad) {
        slot.ad.setTargeting('discourse-category', self.get('category') ? self.get('category') : '0');
        self.set('width', slot.width);
        self.set('height', slot.height);
        window.googletag.display(self.get('divId'));
        window.googletag.pubads().refresh([slot.ad]);
      }
    });
  }).finally(function() {
    String.prototype.w = ember_w_function;
  });
}.on('didInsertElement'),

Nara_Cruz · 2018-05-29 15:20:17 UTC

Thanks @neil that’s exactly what I was looking for. It works great but one thing I noticed is that sometimes I have to do a refresh to get the specific category ad to display or if go to another topic the category ad still displays until a refresh (shift + command + r ).

It appears to be caching.

Any ideas?

Thanks

neil · 2018-05-29 15:41:32 UTC

Do you see any errors in the javascript console? Can you try using the DFP developer console to look for any problems?

Nara_Cruz · 2018-05-29 17:10:24 UTC

No errors at all. I checked the DFP developer console too.

My DFP order has 2 line items setup as “House”. One is “Site Wide” (Synergy Air creative), and the other is “Tools / Tool Kits” (Cleveland Aircraft Tools creative only).

I’m guessing maybe it’s just rotating with the other line item creative in the order. I thought it was kinda odd since the “Site Wide” line item for “Synergy Air” doesn’t have any key-value set nor does it have an active (Cleveland Aircraft Tools creative). I thought when the sub-category page loads (Tools / Tool Kits) that it would only show the line item creative (Cleveland Aircraft Tools) which has the key-value set, but sometimes the Synergy Air creative is displayed.

See:

If you do a Force Refresh you’ll see what I mean.

Any thoughts?

neil · 2018-05-29 17:36:33 UTC

On the “Tools/Took kits” page, I was getting Synergy Air for all reloads, and then it switched to Cleveland and stayed that way for reloads. That makes sense to me if Synergy Air is allowed to show on any page.

Nara_Cruz · 2018-05-29 18:38:24 UTC

I guess I’m a little confused. I need Synergy Air display everywhere except on the “Tools / Tool Kits” category page. If I exclude it from home page “topic list top” it won’t show on the home and other pages besides “Tools / Tool Kits”.

What am I missing?

Should I set the Key-Value in DFP to 'is not" “Tool / Tool Kits” for the Site Wide line item?