No additional feedback on this? When it errors it works fine after I refresh.
Some sort of support responsive ads would be great, specifically for iOS’s split view mode where the wider ads will distort the page.
The dpf banner lacks of dimensions 300x100
You should update them to make it compatible with new dpf rules
Rather than adding all the possible ad sizes, I’ll try to add new settings: responsive, and “unspecified” to get the size from DFP/AdSense. I don’t know why ad sizes are needed in the plugin, but I’ll find out soon enough I’m sure.
I was able to get responsive ads in AdSense working on desktop. An example of a responsive ad that filled the width:
I’ll do mobile next. (For some reason the plugin hard-codes a size of 320x50 on mobile for all AdSense ads…)
So, the solution for DFP going forward is one of these:
- Keep adding more values to the lists of ad sizes
- Remove the lists and change the settings so you enter the arbitrary dimensions you want. (Not sure how to migrate existing DFP users to new settings…)
@broz The plugin has been updated with the new supported ad size in DFP settings, including 300x100.
Getting error: Failed to load resource: the server responded with a status of 400 ()
How to resolve this?
What version of discourse are you using?
What did you do?
Tell us steps to replay.
400 Bad Request can indicate that your DFP publisher ID is wrong. In your DFP console, go to Admin > Global Settings > All network settings and find the number in “Network code”. Mine is 9 digits long.
Also it could mean the ad size that DFP is trying to serve is larger than the ad unit you’ve defined in your Discourse settings. DFP refuses to serve ads that will be cropped.
Any chance of support in the future for Amazon native ads? They do tend to convert better than banner or text ads.
To do responsive properly with JS and defineSlot, can you please provide the following @neil? Thanks in advance!
- List of Discourse viewport widths
- List of ALL the different URLS where the ads can appear.
For example, “dfp topic list top code desktop” & “dfp mobile topic list top code” appear at “/” and “/c” (from what I can tell but I’m 100% sure). We need this so we can create “zones” to map our tags in the JS properly.
- dfp topic list top code
- dfp mobile topic list top code
- dfp topic above post stream code
- dfp mobile topic above post stream code
- dfp topic above suggested code
- dfp mobile topic above suggested code
- dfp post bottom code
- dfp mobile post bottom code
All the urls is all the topic list pages. (e.g., /latest, /unread, etc.), and any topic page (/t/topic-slug/123).
I’m curious what you’re going to do to get it working.
Does it work with Native In-Feed and In-Article Ad blocks?
Status don’t change for Native type blocks…
Status 400 (bad request) is coming from AdSense, and means you need to wait until Adsense approves your new ad units or has some ads to show. It’s hard to say why Adsense is rejecting the request.
A post was split to a new topic: Global statistics on how the number of pageviews correlate to the earnings from ads shown
Global statistics on how the number of pageviews correlate to the earnings from ads shown
3 posts were split to a new topic: Plugin install: found a tab character that violate intendation
Is it possible to use this plugin for simple html banners ?
<a href="affiliate.link"><img src"banner"></a>