Hello community
I’ve been having an alignment problem with the search field with the latest updates. I thought it would be solved with the next updates, but for about 2 weeks now the search field has been looking like this. Any solution suggestions would be appreciated.
Hello ,
Try to reset this setting (meaning, no value):
There is a UX issue when search_button_text
is used.
Thanks for the suggestion but I’ve been using it this way all the time
That’s odd . This is not what I see on your HTML:
Looking at the code, the translation is used in that <span>
:
contents.push(
this.attach("link", {
href: this.fullSearchUrl({ expanded: true }),
contents: () => [
h(
"span",
I18n.t(themePrefix("search_banner.search_button_text"))
),
iconNode("search"),
],
className: "btn search-icon",
title: "search.open_advanced",
})
I think you defined this translation in English locale, but you currently use another language.
I can see it:
Yes, the language is Turkish, but I have been using it this way for 2 years and did not experience any problems. Where could I have gone wrong ?
This is a side-effect of this PR:
discourse:main
← discourse:ui-changes
opened 04:03PM - 09 Nov 23 UTC
This PR fixes overlapping icons to the right of the input. I adjusted the search… icon to appear to the left, following most site standards.
**Before**
<img width="500" alt="image" src="https://github.com/discourse/discourse-search-banner/assets/30537603/32a71381-eec2-4c52-8c31-c3b5166fa3f2">
**After**
<img width="500" alt="image" src="https://github.com/discourse/discourse-search-banner/assets/30537603/888e81ad-7f39-4769-b7ec-c8cd910a371f">
As far as I understand, we need to wait for an update regarding this issue ?
1 Like
This is an issue that needs to be addressed, yes.
For now, you can make it less messy by removing the text you defined for search_button_text
in the English locale.
3 Likes
I just saw that the problem was solved with the update, thank you.
2 Likes
For reference, fixed by Jordan here:
discourse:main
← discourse:search-button-fix
opened 05:02PM - 20 Nov 23 UTC
**Before**
<img width="500" alt="image" src="https://github.com/discourse/disco… urse-search-banner/assets/30537603/f4fb3d18-a836-4e6d-a10c-0127d0e2e218">
**After**
<img width="500" alt="image" src="https://github.com/discourse/discourse-search-banner/assets/30537603/cb67caaf-595d-4d6c-94d6-291b77220116">
4 Likes