Always follow "prioritize username" setting when showing usernames on the interface

UX
1

This is about this site setting:

image
image630×108 5.18 KB

On recent official components and themes, the setting is not considered where the username is shown. For example on Topic Cards, it’s always the username that is shown on the topic list item:

A screenshot of a social media post by "jesse.keebler" with a visible username, author profile picture, published date, and 59 hearts. (Captioned by AI)
A screenshot of a social media post by "jesse.keebler" with a visible username, author profile picture, published date, and 59 hearts. (Captioned by AI)990×124 6 KB

Similarly, on the Horizon Theme:

A user is asking for help on how to add emojis to tags, with a "Support" label next to their message. (Captioned by AI)
A user is asking for help on how to add emojis to tags, with a "Support" label next to their message. (Captioned by AI)990×124 9.67 KB

On the templates, only the username is inserted, e.g. as {{@topic.creator.username}}. To follow the site setting, it would need to be inserted conditionally, like:

{{#if (and @topic.creator.name (not this.siteSettings.prioritize_username_in_ux))}}
  {{@topic.creator.name}}
{{else}}
  {{@topic.creator.username}}
{{/if}}

I did a PR to inlcude this on Topic Cards recently (FEATURE: Show full name if available by nolosb · Pull Request #48 · discourse/discourse-topic-cards · GitHub). However, it would need to be added to the theme as well, and potentially in other places. So I wondered if it makes sense to add the logic each time, or if there should rather be a common component for inserting fullname/username conditionally, following the site setting?

4 Likes