This happens after updating to v1.9.0.beta13 +63
Steps to reproduce:
After this, counters are back to zero.
Does this persist after you refresh the page by pressing f5 in your browser or the refresh button?
Yes, it does.
Also using different browsers (chrome and firefox) show the same numbers, which go back to zero for attachments if the reply is edited.
I have just updated to
v2.1.0.beta1 +1
The “link click counter” bug for file attachments still remains exactly the same as described.
Let’s see
test-text-file.txt (9 Bytes)
I just made an edit to this post, here’s what it looked like before my edit:
Yep confirmed that resets the count for some reason…
This is not as easy as I’d hoped but it’s still on my 
list. Will get it fixed by the end of the week.
So the issue is that we extract links from post several times during the cooking and post cooking process. Since they also change from relative/bare to absolute/cdn in the same process, we’re effectively deleting the links to recreate them later on. Thus losing the clicks count.
I’ve pushed a fix to ensure we always store links to uploads using the URL we keep in the database.
https://github.com/discourse/discourse/commit/bf4d98e89d91df4b35bd2c1cc2c17630dbc0f3c3
Sounds good but I am a bit unclear. Will this fix all posts or just new posts?
It is OK if it is new posts only, I’m just asking.
Old posts will require a rebake (and a click count loss), new posts will be 
.
I rebaked the post above and it doesn’t seem to be working. Let me try a new attachment.
Can everyone reading this please click ↓ ↓
another-test-file.txt (19 Bytes)
Post edited, October 3rd 2018!
Turns out, I also needed to take into account CDN so I extracted the cook_url method from the CookedPostProcessor and used it so we store the same links as the one we cook in the posts
https://github.com/discourse/discourse/commit/de92913bf4761939ed5d8162db8337ffc7c8a00b
This topic was automatically closed after 2 hours. New replies are no longer allowed.