Bcc plugin placeholders not working

Bug
1

The Discourse-bcc plugin’s new feature has a glitch.

When I write this message from the user NathanK to my two test users, the placeholder only seems to work on the first user:

image
image949×460 33 KB

This is what I get for the first user, which is sweet:

image
image772×513 38.6 KB

However, this is what I get for the second user (note that the username is the first user’s):

image
image772×513 38.3 KB

3 Likes
2

Ah, I see what I did wrong. Give me an hour or so and I’ll have a PR with the fix.
https://github.com/discourse/discourse-bcc/pull/7

7 Likes
3

Awesome - I look forward to the merge so it can be used ‘in anger’.

Have you considered bringing the UX a little more in line with the Discourse Canned Replies plugin? For example, using the following instead of {username} and {@username}:

  1. %{recipient_name}
  2. %{recipient_username}
  3. %{@recipient}
1 Like
4

Awesome, fix is now merged!

2 Likes