When I try to search the “Day” part of the Birthday selector, the search bar shows up but doesn’t work when I hit Enter.
Repro Steps:
Browser: "Repro"d on Chrome, Firefox, and Safari
Computer: Mac.
The bug is here on Meta? I successfully changed the day of your birth right now.
Do you have browser extensions? If so can you try to repro it in an incognito window (with no active extensions)?
It’s in meta too. Did you press enter after you typed in a number? Because I can repro in private browsing(No extensions) too.
Yes, I did it using Windows10, maybe it’s something that happens only on macOS.
That’s probably it. Can you try repro on your Mac? I’m wondering if it’s just something with my laptop.
I have no Mac. You should wait for one of my colleague to test it (likely after our annual meeting next week).
Nope, we will try to repro it on Mac early next week.
I can repro this on Firefox for Mac. I’m guessing it has to do with the order of the event when Enter is hit. When you use arrow keys to select a date, it updates just fine when pressing Enter. But in the search box, it closes the window, probably assuming that the same number is selected as prior.
I tried this on my personal site using the chat integration plugin (which also uses select-kit), and I was not able to reproduce. I had a chat with @joffreyjaffeux, and this has to do with the current implementation of select-kit getting confused comparing a string to a number. He’s working on a new version of select-kit, so this should be fixed when that gets rolled out.
This should be fixed by:
https://github.com/discourse/discourse-cakeday/commit/556fa89a65fa728f25d3b3fd2a6cfb46c083afd9