Blockquote button fails when selected text begins with a blank line

I’ve seen the blockquote button fail to work a number of times, seemingly without any reason, but I think I finally figured out how to reproduce it.

If your selection includes a blank line at the beginning, it does not work. It’s a little hard to illustrate, but hopefully this helps (at the end of the recording, I make it work by re-selecting the text and being careful not to select any blank lines above it):

7 Likes

Aha let’s fix that @eviltrout… pretend that redacted client name reported it as a bug :slight_smile:

5 Likes

Fixed here:

https://github.com/discourse/discourse/commit/b9595966d4d32f8020f7a84461c9d544bdd562f6

5 Likes