Quote not working if I get the whole sentences...again, with triple click on Firefox

pr-welcome

(Daniela) #1

Continuing the discussion from Quote not working if I get the whole sentences:

It happens again here on Discourse, on my forum that is still in version 1.9.0.beta12 +21, updated after the fix made by @eviltrout, it continues to work.

The problem is on Firefox 56.0.1, no issue with Chrome.


[infinite loop around text selection] Not possible quote text with emoticon in Firefox 57
(Stephen Chung) #2

You mean triple-click to select the entire paragraph.

When the entire paragraph is selected via triple-click, pressing the Quote button does nothing.

When the entire paragraph is manually selected, pressing the Quote button works.

Still occurs on Meta as well as latest build.


(Daniela) #3

This is true but only with Firefox. On chrome everything works well (triple click and select manually a sentence).

I will update the title


(RĂ©gis Hanol) #4

Unfortunately it’s not an easy problem to fix. We’ve tried multiple times to fix it but it keeps breaking for some reasons…

Feel free to take a stab :crossed_swords: at it though :wink: (#pr-welcome)


(Stephen Chung) #5

What has been the problem preventing the quoting?

I suppose if the quote button appears, it is a matter of checking what is included in the selection that throws it off?


(Mittineague) #6

AFAIK, it has to do with the way Firefox works with the clipboard. I don’t know if the security fixes have become stable enough to make working on it worthwhile, but I’d hope so.


(RĂ©gis Hanol) #7

Something about the double/triple-click selection which makes the selection go past the boundaries of what’s selectable and thus preventing the quote button to show. We could use another css selector but that would mean displaying the quote button when you highlight the buttons under the post…


(Stephen Chung) #8

Well, thing is, the Quote button DOES appear and is clickable.

Clicking on it merely does nothing.