If you can believe it
I have started refactoring/cleaning up the component to use the plugin-style file structure and make use of the new topic thumbnails.
I’ve added a couple new features as well:
image_display_style- there are two options with this. The default should be the behavior the component has had all along. The alternative will ensure there is no cropping and the full image is displayed. It’s hard to say which one is “better” so you’ll want to do some experimentation and see what works best for your workflow and blog images.
mobile_enabled- this is a first pass on the mobile blog post style. I’m interested to hear any bug reports or ideas for improvements on this!
I still want to continue refactoring and cleaning up the code, but this should be a good start.
No plans at this point, I’m afraid!
Thank you for a really inspiring and nice component @tshenry
In my evaluation I have identified two issues;
No blog image in sub categories - after quite extensive troubleshooting with different themes and enabling/disabling both plugins and other components, I think I can state with near certainty that blog images won’t render for sub categories. The first image/the intended blog image is however still hidden.
First image not hidden inline with DiscoTOC - When Blog Post Styling is used together with DiscoTOC, the blog image get rendered above the title correctly - however, it is rendered twice as it is still rendered in its original position as well.
Thanks so much for the feedback @torstensson! Both points were indeed bugs and should now be fixed:
Please let me know if you continue to have any issues.
To everyone using this component:
This component was created with the intention of having an image display above every blog post topic. With that said, it was possible to create a blog post without displaying a featured image by simply not including an image on the first line of the post. This behavior has changed.
The newer implementation greatly improves performance, but it uses a predefined value rather than looking at the post contents itself. The predefined value is generated from the first image found in the post. Unlike before, it is not necessarily limited to an image appearing as the first line of the post. This means if you create a post without an image on the first line, but you include a single image at the bottom of the post, that image at the bottom will now also be displayed above the topic.
I have included an all-or-nothing setting that can toggle on/off the “featured image,” allowing you to have all of the styling except for the featured image if that is your preference.
I am going to update the OP with all of the new considerations and recommendations, but the short of it is to make sure to include an image on the first line of the post (this positioning is still used to make sure the image is not repeated). You may find it is helpful to use a placeholder image in the category’s topic template that can be used as a default if no image is provided.
Awesome, thank you @tshenry I can gladly confirm that both issues have been resolved with the update and again - thank you for a really great component, not only in function but inspiration as well
A recently announced feature may work as an alternative to this theme-component. Leaving it here for those interested.
@tshenry Thanks so much for this component! We are using it along side the Topic List Previews plugin to create an Articles section for students in the Dataquest Community.
I have a feature request for you to consider in future iterations of this component - Can you please add the ability to add Canonical URLs to the articles?
Search engines use canonical links to determine and prioritize the ultimate source of content, removing confusion when there are multiple copies of the same document in different locations.
So I think this is a great component. In fact I am now trying it out on a live Discourse and I am playing around with it. Without any kind of order, I want to provide my initial thoughts and feedback, hope it helps - forgive me if some of them might be more of a question:
- The way the author is displayed is a bit out of place and could maybe be solved more space-efficient, to tie it in closer with the title, or category tag etc… there is also rather much white space between the line that ends the author info and the beginning of the text
- It is hard for a vistor sent directly to a blog post to realize where you are, as there is no clear breadcrumb or anything. The main reason is, that the title bar seems to be turned inactive, whereas on normal topics they transform and include the title, category etc.
- Would be great if the category view could have more of a blog look, with small preview images and such, would that be hard to do?
- I don’t see a category description in the category view?
wow what theme component is used for that category view? Looks cool
Thanks for the feedback
I do agree there is a lot of white space around the author/title area. I’ll keep this feedback in mind next time I work on the component and see if I can come up with something.
I’m not 100% sure what you mean here. The header will switch to include the title/breadcrumbs once you scroll down past the image and blog title. You are correct that at the top of the page, it’s not especially obvious, though. I’ll keep this in mind as well.
These would be out of scope for this component. For the category view, you might want to take a look at: Topic List Thumbnails Theme Component
Thanks for the feedback I think most of it is cleared up, and I also do see the category description now, not sure why it wasn’t visible earlier, I thought it had something to do with the component. I will keep trying this out and post more feedback later. Excellent work!
I think the excess space at the top comes from space remaining after the picture is “moved” to the header of the blogpost, resulting not in space below gained, but being empty.
But I noticed an actual problem: If I post links to such a blog post in other topics, there is no thumbnail, see here
I’m fairly sure this is due to you excluding a line break between the image upload link and the first paragraph. Can you try editing it to match the following:
![spagh|690x390](upload://nVi42gGIwt03DAYSzVEc4RvwS6h.jpeg) <big>While</big> there is ample space around the web to post and blog and share and tweet and all that, my favorite place to exchange ideas with all of you on the spaghetti western is this forum. Some of you might remember an effort dating back several years ago, it was called "Planet Spaghetti Western", and the idea was to have a blog, that would automatically aggregate posts from all the spaghetti western blogs around the internet, and present them sort of as a digest. It was rather complicated from a technical perspective and in the end more work than it was worth so I had to shut that down.
If that works, I’ll add a note in the OP about that requirement.
Hi. That reduces the margin a bit, indeed, thank you. I had done the exact opposite in the editor: leave as little space between the image and the beginning of the text
Would it be possible to indicate somehow which photo on the page you wanted at the top.
A pair of tags like
<big></big> something like
Unless I’m misunderstanding, it shouldn’t be necessary. If you follow this:
It will display the image above the topic. If you want to include the image again later in the post, that’s totally fine.
Thanks for the workaround.
If it could be implemented using something like
<top></top>this would negate
the need to put the image first line.
the need for exact formatting with the blank line.
the need to duplicate the image
I just pushed a small fix to address some styling issues I noticed. They likely came up as a result of recent changes in core. Let me know if there are any issues!