Bookmark button class


#1

Let me preface this by saying I’m no dev so go easy :sweat_smile:

I’ve noticed a class on the Bookmark button on the topic view “doesn’t get generated” (It just says {{bookmarkClass}} ) ?


(Jeff Atwood) #2

Where exactly are you seeing that? Looks OK in your post, above, if I use the f12 browser inspector on the bookmark button, I see:

<button class="widget-button btn-flat bookmark no-text btn-icon" aria-label="bookmark this post" title="bookmark this post"><i class="fa fa-bookmark d-icon d-icon-bookmark" aria-hidden="true"></i></button>


#3

Using inspector on this topic view. I havent checked other status’ of this to be fair so I cant account for other instances.

Edit:
Chrome: Version 69.0.3497.100 (Official Build) (64-bit)
OS: MacOS Mojave 10.14


(Jeff Atwood) #4

Oh at the topic level. Sure.

Confirmed:

<button aria-label="Click to bookmark the first post on this topic" title="Click to bookmark the first post on this topic" id="ember1617" class="btn-default {{bookmarkClass}} btn btn-icon-text ember-view"> <i class="fa fa-bookmark d-icon d-icon-bookmark"></i><span class="d-button-label">Bookmark<!----></span></button>

We should fix that… @david would you like the honors? :bowing_man:


#5

Confirmed for FF too :slight_smile:

Edit: @codinghorror I believe they call that delegating :smiley:


(David Taylor) #7

Fixed in

(cc @awesomerobot)


(David Taylor) #10

This topic was automatically closed after 30 hours. New replies are no longer allowed.