Not sure when it broke but when you bookmark a topic using the f keyboard shortcut it doesn’t update the UI. Requires a reload of the page to appear.
6 Likes
Using b - as listed in the shortcut menu - seems to work correctly for bookmarking (unless I’ve misunderstood the issue).
1 Like
Yeah, b works fine, but f doesn’t. It should update the bookmark icon of the first post of a topic.
Ah, sorry. I didn’t even realise f still existed as a shortcut, after the demise of starred topics. 
Testing just now (Firefox 47 on Ubuntu Gnome 16.04), it bookmarks the first post but requires a reload for the bookmark to show, as you say. Using it to toggle the bookmark off again produces a “Sorry, an error has occurred” message, although reloading the page reveals that sometimes the bookmark has cleared and sometimes it has not. 
Also, you get a non-descriptive error message when you press f too often.
Sorry, an error has occurred.
The error message for b is a lot better:
We have a daily limit on how many times that action can be taken. Please wait 56 seconds before trying again.
4 Likes
Confirmed, still the case, @eviltrout this looks like an easy fix.
Okay I have two fixes here. One restores the keyboard shortcut, and one shows a better error message if you go over your rate limit:
https://github.com/discourse/discourse/commit/ae15b10cf8c991ec0745a4d843ad243eafc9a4e5
https://github.com/discourse/discourse/commit/a1baf739569841c030ffd15e84045ab5c1755630
5 Likes