Bookmarking a topic doesn't update the post controls


(Régis Hanol) #1

Not sure when it broke but when you bookmark a topic using the f keyboard shortcut it doesn’t update the UI. Requires a reload of the page to appear.


(TechnoBear) #2

Using b - as listed in the shortcut menu - seems to work correctly for bookmarking (unless I’ve misunderstood the issue).


(Régis Hanol) #3

Yeah, b works fine, but f doesn’t. It should update the bookmark icon of the first post of a topic.


(TechnoBear) #4

Ah, sorry. I didn’t even realise f still existed as a shortcut, after the demise of starred topics. :blush:

Testing just now (Firefox 47 on Ubuntu Gnome 16.04), it bookmarks the first post but requires a reload for the bookmark to show, as you say. Using it to toggle the bookmark off again produces a “Sorry, an error has occurred” message, although reloading the page reveals that sometimes the bookmark has cleared and sometimes it has not. :confused:


(Gerhard Schlager) #5

Also, you get a non-descriptive error message when you press f too often.

Sorry, an error has occurred.

The error message for b is a lot better:

We have a daily limit on how many times that action can be taken. Please wait 56 seconds before trying again.


(Sam Saffron) #6

Confirmed, still the case, @eviltrout this looks like an easy fix.


(Robin Ward) #7

Okay I have two fixes here. One restores the keyboard shortcut, and one shows a better error message if you go over your rate limit:


(Robin Ward) #8