Bulk Invitations need a confirmation dialog


(Joshua Frank) #1

This is probably not a bug as such, but a very troublesome feature. I was trying to Bulk Invite From File, and got a nasty shock when I uploaded the file and it immediately sent the email to 30 people. I guess I assumed there would be a step where it shows that the file uploaded and then offered a button to actually do the send. So I uploaded the file–intending just to familiarize myself with the process–and embarrassed myself by sending invitations before a key piece was ready. I had to send a manual followup explaining the glitch.

I really think that Bulk Invite button needs a confirmation or other speed bump, because the consequences are fairly drastic.


#2

I can see how this would be embarrassing. You are right, not a bug (but you got throttled unexpectedly).


(Jeff Atwood) #3

Sure @techapj when you get back, can you add a dialog that shows the count, e.g.

You’re about to email invites to {n} people.

Go ahead cancel


(Joshua Frank) #4

I think that will be much better! Thanks.


(Sam Saffron) #5

OK Adding a #pr-welcome on this, it would be an improvement in quality of life and easily can be added by the community.


(Saurabh Patel) #7

Hi,
I have created PR for the same. But i had to make some modifications to the confirmation popup.

Currently, CSV is processed fully in back-end so it will need some front-end processing to get number of rows in file. That’s why I have just added a generic popup Are you sure? instead. I think it should be fine since our purpose is more of giving a confirmation dialog to user before proceeding.

If we want to check after file is uploaded and before invites are not sent, it will require a major cleanup on front-end and back-end. Front-end uses a mix-in for upload which is used at multiple places so modifying it can create a big issue. Back-end is also coupled to do processing of CSV and sending invites in one go.


(Robin Ward) #8

I understand that it’s significantly more work to show the row count here, but I’m also not happy with the generic “Are you sure?” message. I’d suggest something like this instead:

You’re about to email invites to everyone in the uploaded file.

Go ahead cancel


(Saurabh Patel) #9

This is already fixed thus can be closed.

It was fixed here: FIX:show popup before bulk invite by mrfinch · Pull Request #6761 · discourse/discourse · GitHub

Thanks


(Joshua Rosenfeld) closed #10

This topic was automatically closed after 42 hours. New replies are no longer allowed.