Can we add ember add-ons to a discourse plugin? (like ember power select)

Dev
1

I’d like to add some ember add-ons to a plugin.

Here’s an example: Ember’s Power Select.

(This helps with drop-downs. Discourse uses select-kit, which I know is also powerful, but I find it hard to customize because its heavily abstracted in the code base. So I’d like to try power select).

In a normal Rails/Ember app, I think I would just add the add-on with:

$ ember install ember-power-select

Then I’d add stuff like the following:

hbs template:

<PowerSelect @options={{this.names}} @onChange={{this.foo}} as |name|>
  {{name}}
</PowerSelect>

javascript file that goes along with it:

    import Controller from '@ember/controller';
    export default class extends Controller {
      names = ['Stefan', 'Miguel', 'Tomster', 'Pluto']
      foo() { }
    }

But a Discourse plugin is not a standard Rails app. Is there something special I need to do to get it working?

3 Likes
2

Well, I watched this wondering if you’d get any hints, but here we are 4 days later.

I’m pretty novice at Ember, but I’m fairly certain that you’ll be much better off if you manage to deal with the “heavily abstracted” stuff and play by those rules. Not only is pulling in other add-ons hard to figure out, but it’s also going to be hard to maintain.

1 Like
3

We are upgrading Discourse over to EmberCLI, and we are pretty close to it now:

4

Thanks, all.

I’d seen that before, but am glad to have the confirmation that it is not possible to add Ember add-ons until that upgrade is done. So it sounds like adding ember add-ons will be possible soon–once the upgrade is complete. And that sounds great.

I think that’s an interesting question. Here’s my two cents:

In terms of using the discourse “abstracted stuff” v ember add-ons: I could be wrong, but I think that using ember add-ons for specific tasks in plugins might be easier to maintain, in the cases where you are trying to do something different than what Discourse is doing already. This is my thinking:

Example here is wanting to add a brand new drop-down in a plugin. That distinction is probably important–I’m talking here about trying to do new things in a plugin that are not done in the discourse code-base, and the question is whether to start with discourse methods or a separate add-on.

A lot of times you really don’t have a choice. For example, if I wanted to add a custom field to topics, I’d always customize on top of discourse’s pre-built methods and code.

But If its a targeted piece of functionality–like a drop-down for a new purpose–I’d already be in the case where, if I use the discourse methods, I’d be adapting them to things they weren’t targeted towards.

Option 1: I could try to take the select-kit code I see in, say, category-chooser, and insert it in a new spot (that’s not about categories), and then try to customize it to be about what I want the dropdown to be about, instead of categories. This is the task that I described earlier as being tricky.

And it could be difficult to maintain–because if the discourse team changes something in how the category-chooser select-kit code works, then that could change my new customized drop-down, but in ways that could be surprising (bc I had customized it so it works slightly differently than the actual category-choose dropdown).

Option 2: I could insert something from ember that is robust but that is also made to be customized, where I can see fairly clearly how the code actually works. In that case, I might miss out cool new features that discourse might add to its drop-downs, but I would be able to stay on top of how my drop-down works more easily. So this is probably the best option, I think, if it is possible.

Option 3: Code it entirely from scratch. That’s where I’ve been tending to end up. When the coding is done, it’s nice to have code that I fully understand and can customize. But of course it takes longer, and (the initial versions at least) are unlikely to be as powerful and robust as what the discourse team or the ember team have built.

3 Likes
5

Bump, and to add it would be great to add support for Ember add-ons to Theme Components …

6 Likes
6

Bump.
If we add addon to discourse such
cd app/assets/javascripts/ && yarn add LIB_NAME
How will this addon be available in the plugin?

7

Just wondering whether this is possible nowadays ? (And if so, how?)

2 Likes
8

I’m afraid not. Ember addons can be added to Discourse core, but not via plugins. We might eventually add some way for plugins/themes to specify npm dependencies, but it’s not on the immediate roadmap.

2 Likes
9

Was literally Googling for this same thing.

– Side question for @david while not availiable via plugins, could we theoretically add a plugin to core and then use it in a plugin if we’re self hosting? If so how? (tried adding to package.json in at app/assets/javascripts/discourse but no luck loading it I would imagine because I’m missing something simple.

1 Like
10

yes, but you really don’t want to fork Discourse and then try to pull in all of the commits. Everyone who has done that is very sorry that they did.

Hmm. But if it’s just the one file, you could conceivably have your app.yml copy the file from somewhere into /var/www/discourse right after it cloned Discourse. I think I’ve done that before to change the limits in site settings.

2 Likes
11

Yeah as @pfaffman mentioned you might be able to hack it into working via some app.yml modifications. You’d have to make sure the modification was done before the yarn install and assets:precompile steps.

But this is totally unsupported, and may break unexpected things. I wouldn’t recommend it.

Out of interest, which addon were you hoping to use?

2 Likes
12

Hadn’t really gotten that far, however, I’ve found that most popular addons have functionality that already exists within Discourse itself. The appeal of addons is that generally the documentation is a little bit better and the available resources if you get stuck are pretty well fleshed out. For instance there is a wealth of documentation and issues that are “solved” with ember-concurrency so if you’re a new dev, having access to that addon would usually mean you can get up and running a little easier.

But as I said it was more of a wonder than a want.

1 Like
13

So you’re literally looking for trouble. I’d recommend not considering any addon until you find that the existing resources don’t meet your needs.

But you don’t know that it’s going to be compatible with how discourse solves that problem today or in the future. If you want to develop for Discourse then looking at examples of how things work in discourse is going to be the way to go.

Don’t be the guy looking for his keys under the lamp rather than under the car where he dropped them because you can see better under the lamp.