Canceling an image load can leave the Uploading stuck


(Peter N Lewis) #1

If I upload an image, and cancel the upload, it can get in a stuck state:

20171028-110958

The spinner is still spinning, but is clearly never going to finish, and I can no longer press Reply when stuck in this state,

If I cancel the reply, and then click reply again, it is still stuck in the state, although now it says “Uploading 0%”.

I have to reload the page to get it unstuck.

This is Discourse 1.8.9, Safari/Sierra (10.12.6)


(Régis Hanol) #2

I’ve heard that bug but was never able to reproduce locally. Any chances you could find reproduction steps?


(Peter N Lewis) #3

Yep, I think I have it - it happens on the second drag/cancel.

Safari/Mac OS X 10.12.6 (Sierra).

  • Reply
  • Drag a large image in
  • Wait for it to start
  • Cancel
  • Drag a large image in
  • Wait for it to start
  • Cancel

This caused the bug every time for me.


(Régis Hanol) #5

I’m pretty sure this has been fixed by @gerhard.

@peternlewis can you confirm this has been fixed?


(Gerhard Schlager) #6

I fixed it on mobile, because it didn’t work there at all after the composer refactoring.

This bug seems to describe a different issue.


(Régis Hanol) #7

Ok, I’ll have a look then.


(Régis Hanol) #9

I did try on Windows 10 / Chrome 63.0.3239.132 and could not reproduce the issue. I was always able to properly cancel the upload.


(Peter N Lewis) #12

Yes, it appears fixed. Thanks.


(Régis Hanol) #13