Cannot undo a revision if it only includes tag edits

Bug
1

I was reviewing history of revisions for the first post of a topic. I noticed that one of the revisions incorrectly removes tags that should be attached to the topic. The revision didn’t change the content of the post, just the tags. When I press “Revert to revision 12”, I get a message saying “The current version is same as the version you are trying to revert to.” and I’m unable to quickly restore the tags from the previous revision

image
image791×213 21.1 KB

2

Can you make an exact repro of this and give us steps?

3

I can repro :raised_hand:

My step by step:

  • Reduce Editing grace period to 0 to help speed up the test (optional)
  • Create a topic with some tags and publish
  • Edit the topic to remove the tags, and save
  • Open edit history and attempt to revert to re-add the tags

Expected: post revision revert would occur as normal and return the topic to its previous state where the tags were included

Actual: error message blocking revert

The image shows a user interface for editing revisions in TinyMCE, where a message displays that the current version is unchanged and prompts for an OK action. (Captioned by AI)
The image shows a user interface for editing revisions in TinyMCE, where a message displays that the current version is unchanged and prompts for an OK action. (Captioned by AI)1179×1509 104 KB

Though if the expectation is that you could rewind to a much earlier edit in the history that removed the tags and you wanted to revert only the tag removal and none of the later edits to the post body then this wouldn’t be expected to work as the edit history (including tag edits) is sequential. A revert in that case would be expected to add the tags back in and also remove any later edits to the post body as well.

2 Likes
4

@JammyDodger that’s exactly right, thank you for the repro steps!

I am aware of that. In my case I was notified of a moderator making changes in one of my topics, and the tag changing revision was the latest one

1 Like
5

This seems pretty self contained, thanks for the excellent repro steps @JammyDodger

Putting a pr-welcome on this for now!

1 Like
6

On the button that says ‘Revert to revision’ does revision mean draft/version?
(When you do revert, the message in History says ‘reverted to version #x’, so I assume it does)

If it does, here’s a related bug (I think it makes more sense to address both in a single patch):

Create a new topic → (Title1, Text1)
Edit title only → (Title2, Text1)
Edit text only → (Title2, Text2)
Revert to the first draft

Expected output: (Title1, Text1)
Actual output: (Title1, Text2), which incidentally isn’t any of the drafts

You can change text first and title second with similar effect or use category instead of either title or text.