Can't create new tags?

Bug
1

Hey guys. I just realized that I can’t create a new tag.

It doesn’t work in any way:

  • when composing new topic
  • when editing topic
  • when editing topic title & category.

I don’t think it’s a permission thing, since I tried to create them while I was logged in as admin.

There is no error log, in either /logs or console, just nothing happens when I press Enter in the tag popup:

I’m not sure when exactly the problem arised, but it’s pretty recent, because i have a new tag created just couple of days ago.

I’m up to date with everything:

Pasted image705×463 35.5 KB

Totally unrelated question: can I use wildcards on staff tags? I.e. admin-*?

Thanks!

2

Can we repro this @techapj ? Any errors in your logs?

3

Let me have a quick look, I had to change some stuff there for tag prefs

4

I think this should fix it:

https://github.com/discourse/discourse/commit/c5c443fda3d7001e2d0947506b06de307fb0af24

5 Likes
5 
Uncaught TypeError: this.get is not a function

on this line:

if (!term.length || !this.get('allowCreate')) return;

I think it might be a problem of scoping?

6

Apologies for the sloppiness, trying to rush a fix here and no proper access to my dev env

Try this:

https://github.com/discourse/discourse/commit/64ca5552bceef54fca7da51da0c2f933ef1ac148

9 Likes
7

Indeed it works! Thanks a lot!

3 Likes